Page MenuHomePhabricator

Allow for serializing/deserializing an ecash address

Authored by Fabien on Sep 14 2021, 12:42.


Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task

This diff adds serialization/deserialization to the CashAddrContent object, so that an ecash: address can be send part of a p2p message without requiring a script nor full string encoded (which is less compact) nor a script.

Ref T1676.

Test Plan
ninja check

Diff Detail

Event Timeline

Fabien requested review of this revision.Sep 14 2021, 12:42

I don't understand what that does, considering the address is a representation of a script to begin with.

deadalnix requested changes to this revision.Sep 14 2021, 23:24

I don't think it makes sense to have many different way to serialize the exact same thing, or to back the addresses in the consensus layer. None of this seems to me to be a good idea.

This revision now requires changes to proceed.Sep 14 2021, 23:24
Fabien planned changes to this revision.Sep 15 2021, 13:57