We no longer have a concept of "since last difficulty adjustement", now
that the difficulty is adjusted for each new block.
Remove that option from the getnetworkhashps RPC and throw an error.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- getnetworkhashps_negative
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 16712 Build 33274: Build Diff build-debug · build-without-wallet · build-diff · lint-circular-dependencies · build-clang-tidy · build-clang Build 33273: arc lint + arc unit
Event Timeline
Comment Actions
This is incomplete: you make the feature unreachable, but don't remove it. This results in dead code that can is hard to understand because there is no traceable legacy use case anymore.
Comment Actions
There are 2 issues here:
- You also changed the behavior when nblock = 0, with no test (and yes the RPC doc was wrong previously)
- Since you're changing the behavior of the RPC, and this feature is potentially used by miners (I can imagine switching miners using that), this needs to go through a deprecation phase first.
src/rpc/mining.cpp | ||
---|---|---|
59 | That seems redundant with the above check. | |
68 | lookup is no size_t |