Rename SendMessage to SendZmqMessage.
ClosedPublic
Actions

Authored by PiRK on Oct 8 2021, 12:02.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC5fcbf32ac022: Rename SendMessage to SendZmqMessage.

Summary

Windows headers define SendMessage as a macro, which leads to problems
with the method name "SendMessage". To circumvent this, we rename the
method to "SendZmqMessage".

This is a backport of core#13686 [5/5]
https://github.com/bitcoin/bitcoin/pull/13686/commits/6fe2ef2acb00b1df7f6a0c0dea1a81a1924be0e1

Depends on D10285

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 8 2021, 12:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 8 2021, 12:02

PiRK requested review of this revision.Oct 8 2021, 12:02

teamcity edited the summary of this revision. (Show Details)Oct 8 2021, 12:02

Harbormaster completed remote builds in B16937: Diff 30387.Oct 8 2021, 12:33

Fabien accepted this revision.Oct 8 2021, 19:32

This revision is now accepted and ready to land.Oct 8 2021, 19:32

Closed by commit rABC5fcbf32ac022: Rename SendMessage to SendZmqMessage. (authored by Daniel Kraft <d@domob.eu>, committed by PiRK). · Explain WhyOct 11 2021, 07:04

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC5fcbf32ac022: Rename SendMessage to SendZmqMessage..

Revision Contents
Changeset List

Path

Size

src/

zmq/

zmqpublishnotifier.h

2 lines

zmqpublishnotifier.cpp

13 lines

Diff 30405

View Options

src/zmq/zmqpublishnotifier.h