Page MenuHomePhabricator

[avalanche] Add network permission for a peer to send unrequested compact proofs

Authored by Fabien on May 31 2022, 12:10.


Group Reviewers
Restricted Project

Processing compact proofs can be time consuming as the node has to loop over all its proofs to match against each short id. In order to prevent a peer from vasting our CPU time only the compact proofs message (avaproofs) that have been requested will be processed.

This diff adds a new network permission that bypass this and let a peer send unrequested compact proofs. This will make it much easier to test the behavior of a node receiving such a message in functional tests.

Test Plan
ninja check

Diff Detail

Event Timeline

Fabien requested review of this revision.May 31 2022, 12:10
deadalnix requested changes to this revision.May 31 2022, 12:42
deadalnix added a subscriber: deadalnix.

I don't understand what's the purpose of this. At no point we should expect a node to send the whole set of proof without being requested. I don't think solves any problem.

This revision now requires changes to proceed.May 31 2022, 12:42