[tests] bump timeout for receiving proof in get_ava_p2p_interface
ClosedPublic
Actions

Authored by PiRK on Feb 2 2023, 17:24.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC5ba9ccf878f3: [tests] bump timeout for receiving proof in get_ava_p2p_interface

Summary

I saw a CI failure due to a proof being received after 3 seconds: https://reviews.bitcoinabc.org/D13097#290754

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

bump_timeoutabc_p2p_compactproofs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21920
Build 43475: Build Diff	build-clang-tidy · build-without-wallet · build-clang · build-debug · build-diff
Build 43474: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 2 2023, 17:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 2 2023, 17:24

PiRK requested review of this revision.Feb 2 2023, 17:24

PiRK mentioned this in D13100: [tests] show the proofid when representing a proof.Feb 2 2023, 17:33

Harbormaster completed remote builds in B21920: Diff 37799.Feb 2 2023, 17:40

The proof in the CI failure was nearly 4 seconds so 5 seconds may not be enough headroom. But this does bring this timeout up to match other similarly short timeouts in avatools. If we hit these timeouts in the future we should look at a more general fix instead of bumping with each failure.

This revision is now accepted and ready to land.Feb 2 2023, 19:22

Closed by commit rABC5ba9ccf878f3: [tests] bump timeout for receiving proof in get_ava_p2p_interface (authored by PiRK). · Explain WhyFeb 3 2023, 07:43

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC5ba9ccf878f3: [tests] bump timeout for receiving proof in get_ava_p2p_interface.

PiRK mentioned this in rABC395893c395cf: [tests] show the proofid when representing a proof.Feb 15 2023, 08:02