Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC71ba268ed11b: deprecate softforks from getblockchaininfo RPC

Summary

This removes a bunch of code related to the currently empty "softforks" output of the getblockchain RPCs.
The field itself is kept (DEPRECATED) but the value will now always be empty. This only makes a difference on testnet for the testdummy deployment (which will be removed in D13158).

Depends on D13156

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22079
Build 43793: Build Diff	build-diff · lint-circular-dependencies · build-without-wallet · build-debug · build-clang-tidy · build-clang
Build 43792: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 22 2023, 14:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2023, 14:18

PiRK requested review of this revision.Feb 22 2023, 14:18

PiRK added a child revision: D13158: remove most of versionbits / BIP9 related code.

Harbormaster completed remote builds in B22055: Diff 37996.Feb 22 2023, 14:37

Fabien requested changes to this revision.Feb 22 2023, 16:56

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/rpc/blockchain.cpp
1771 ↗	(On Diff #37996)	This should go through a deprecation cycle first. I suggest you leave it empty for this diff (that's the same as current output)

This revision now requires changes to proceed.Feb 22 2023, 16:56

go through a deprecation cycle, add a release note, adjust functional test ("softforks" key is kept with -deprecatedrpc=softforks, value is now empty even on regtest).

Harbormaster completed remote builds in B22075: Diff 38025.Feb 24 2023, 11:12

Fabien added inline comments.Feb 24 2023, 12:22

test/functional/rpc_blockchain.py
172 ↗	(On Diff #38025)	Please move this to rpc_deprecated.py so we don't keep it more than needed

move test to rpc_deprecated

undo a now unrelated style change (at some point in my iterations I added the -deprecatedrpc arg here)

Harbormaster completed remote builds in B22078: Diff 38028.Feb 24 2023, 14:04

Harbormaster completed remote builds in B22079: Diff 38029.Feb 24 2023, 14:21

Fabien accepted this revision.Feb 24 2023, 15:15

This revision is now accepted and ready to land.Feb 24 2023, 15:15

Closed by commit rABC71ba268ed11b: deprecate softforks from getblockchaininfo RPC (authored by PiRK). · Explain WhyFeb 24 2023, 16:54

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC71ba268ed11b: deprecate softforks from getblockchaininfo RPC.

deprecate softforks from getblockchaininfo RPC
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 38029

doc/release-notes.md

src/CMakeLists.txt

src/consensus/params.h

src/deploymentinfo.h

src/deploymentinfo.cpp

src/rpc/blockchain.cpp

src/test/versionbits_tests.cpp

src/versionbits.h

src/versionbits.cpp

test/functional/rpc_blockchain.py

test/functional/rpc_deprecated.py

deprecate softforks from getblockchaininfo RPCClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38029

doc/release-notes.md

src/CMakeLists.txt

src/consensus/params.h

src/deploymentinfo.h

src/deploymentinfo.cpp

src/rpc/blockchain.cpp

src/test/versionbits_tests.cpp

src/versionbits.h

src/versionbits.cpp

test/functional/rpc_blockchain.py

test/functional/rpc_deprecated.py

deprecate softforks from getblockchaininfo RPC
ClosedPublic
Actions

Revision Contents
Changeset List