Page MenuHomePhabricator

[Cashtab] [Alias] Enable alias usage for one to many XEC tx
AbandonedPublic

Authored by emack on Mar 14 2023, 02:44.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

T2990

Putting this on hold given upcoming refactoring to alias caching mechanism.

Enable one to many alias inputs, including a mixture of eCash addresses and aliases.

Test Plan
  • npm start
  • navigate to the send screen and toggle the multiple recipient option
  • input a mixture of valid ecash address with one valid alias address, all with correct XEC amounts, and ensure no validation errors. Send it and validate the tx on explorer.
  • using the same multi-recpient input from above, change the send value of the alias row to below minimum (5.5) and ensure it is invalidated and the Send button is disabled.
  • change the alias row to a valid alias format but yet to be registered address and ensure the eCash Alias does not exist or yet to receive 1 confirmation is displayed
  • change the alias row to an invalid eCash address and invalid alias format and ensure the eCash Alias does not exist or yet to receive 1 confirmation is displayed
  • enter a new empty row and ensure the input is invalidated
  • test with all valid aliases and ensure no errors
  • test with all but one invalid alias and ensure the error matches whether it is the alias format, registration status or minimum send amount
  • ensure no regression to eCash address validation

Diff Detail

Repository
rABC Bitcoin ABC
Branch
aliasOneToMany
Lint
Lint Errors
SeverityLocationCodeMessage
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:1ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:3ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:4ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:5ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:6ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:7ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:8ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:9ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:10ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:11ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:12ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:13ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:14ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:15ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:16ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:17ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:18ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:19ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:20ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:21ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:22ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:23ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:24ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:25ESLINTno-unused-vars
Errorweb/cashtab/src/utils/__tests__/cashMethods.test.js:26ESLINTno-unused-vars
Unit
No Test Coverage
Build Status
Buildable 22419
Build 44464: Build Diffcashtab-tests
Build 44463: arc lint + arc unit

Event Timeline

emack requested review of this revision.Mar 14 2023, 02:44
emack planned changes to this revision.Mar 14 2023, 02:44

Repushed as D13610 due to the significant changes from migrating cashtab location in the monorepo