diff --git a/doc/release-notes.md b/doc/release-notes.md --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -4,4 +4,6 @@ -This is a maintenance release with no user-visible change. +This release includes the following features and fixes: + - The `sharing` field from the `getavalancheinfo` RPC was deprecated since + v0.28.0 and has now been removed. diff --git a/src/rpc/avalanche.cpp b/src/rpc/avalanche.cpp --- a/src/rpc/avalanche.cpp +++ b/src/rpc/avalanche.cpp @@ -659,10 +659,6 @@ {RPCResult::Type::STR, "verification_status", "The proof verification status. Only available if the " "\"verified\" flag is false."}, - {RPCResult::Type::BOOL, "sharing", - "DEPRECATED: Whether the node local proof is being " - "advertised on the network or not. Only displayed if the " - "-deprecatedrpc=getavalancheinfo_sharing option is set."}, {RPCResult::Type::STR_HEX, "proofid", "The node local proof id."}, {RPCResult::Type::STR_HEX, "limited_proofid", @@ -767,10 +763,6 @@ : "pending inbound connections") : state.GetRejectReason()); } - const ArgsManager &args{EnsureAnyArgsman(request.context)}; - if (IsDeprecatedRPCEnabled(args, "getavalancheinfo_sharing")) { - local.pushKV("sharing", sharing); - } local.pushKV("proofid", localProof->getId().ToString()); local.pushKV("limited_proofid", localProof->getLimitedId().ToString()); diff --git a/test/functional/rpc_deprecated.py b/test/functional/rpc_deprecated.py --- a/test/functional/rpc_deprecated.py +++ b/test/functional/rpc_deprecated.py @@ -37,7 +37,6 @@ "-avaminavaproofsnodecount=0", "-whitelist=noban@127.0.0.1", "-avalanchestakingrewards=1", - "-deprecatedrpc=getavalancheinfo_sharing", "-deprecatedrpc=getstakingreward", ], ] @@ -65,14 +64,6 @@ self.restart_node(0, extra_args=self.extra_args[0] + proof_args) self.restart_node(1, extra_args=self.extra_args[1] + proof_args) - info0 = self.nodes[0].getavalancheinfo() - info1 = self.nodes[1].getavalancheinfo() - - assert "local" in info0 - assert "local" in info1 - assert "sharing" not in info0["local"] - assert "sharing" in info1["local"] - self.connect_nodes(0, 1) now = int(time.time())