src/amount.cpp
15 ↗	(On Diff #4646)	Can this be rolled up into amount.h? Doesn't look like there's much use in having a separate file for just this 1-liner function.

This revision now requires changes to proceed.Aug 24 2018, 21:27

schancel added inline comments.Aug 24 2018, 21:30

src/amount.cpp
15 ↗	(On Diff #4646)	I don't see a good reason to do that. Then you need tinyformat in amount.h, etc.

jasonbcox accepted this revision.Aug 24 2018, 21:32

jasonbcox added inline comments.

src/amount.cpp
15 ↗	(On Diff #4646)	good point

This revision is now accepted and ready to land.Aug 24 2018, 21:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3121: Diff 4646.Aug 24 2018, 21:59

Closed by commit rABC87d967d48f27: Move CFeeRate into its own source files (authored by schancel). · Explain WhyAug 24 2018, 22:04

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

1 line

2 lines

63 lines

54 lines

1 line

80 lines

	feerate.cpp
	amount.cpp

8 lines

policy/

policy.h

1 line

primitives/

transaction.h

1 line

Diff 4647

View Options

src/CMakeLists.txt

View Options

src/Makefile.am

View Options

src/amount.h

View Options

src/amount.cpp

View Options

src/config.h

View Options

src/feerate.h

View Options

src/feerate.cpp

View Options

src/policy/policy.h

View Options

src/primitives/transaction.h

Move CFeeRate into its own source filesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4647

src/CMakeLists.txt

src/Makefile.am

src/amount.h

src/amount.cpp

src/config.h

src/feerate.h

src/feerate.cpp

src/policy/policy.h

src/primitives/transaction.h

Move CFeeRate into its own source files
ClosedPublic
Actions

Revision Contents
Changeset List