[electrum] exclude the regtest directory from the unit test discovery
ClosedPublic
Actions

Authored by PiRK on Jun 26 2025, 12:00.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa8368330e72b: [electrum] exclude the regtest directory from the unit test discovery

Summary

In a future diff I want to replace the pytest framework with the regular the unittest module for functional tests (electrumabc/tests/regtest/), but we don't want these functional tests to be found and executed by the unit test runner. They will need to run with their own framework, with a node compiled...etc

Add a simple filter class to skips all tests that contain "regtest" in their fully qualified module name (e.g electrumabc.tests.regtest.test_rpc_misc)

Test Plan

Rebase on D18293 and try:
cd electrum && python test_runner.py

See that it doesn't fail because of the functional tests not finding bitcoind.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 26 2025, 12:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 26 2025, 12:00

remove irrelevant commments from a previous iteration

Harbormaster completed remote builds in B33695: Diff 54592.Jun 26 2025, 12:02

Harbormaster completed remote builds in B33696: Diff 54593.

PiRK edited the summary of this revision. (Show Details)Jun 26 2025, 13:10

PiRK added inline comments.Jun 26 2025, 13:15

electrum/test_runner.py
32 ↗	(On Diff #54593)	A TestSuite can contain other TestSuite recurvisely. The leaves of the tree will not be a TestSuite, but rather a `unittest.TestCase`

PiRK added inline comments.Jun 26 2025, 14:41

electrum/test_runner.py
12–14 ↗	(On Diff #54593)	This is still needed, as the error happens during discovery, before we can filter out the test case based on its module name.