Page MenuHomePhabricator
Differential D18339

[electrum] scripted-diff: use some Qt6 enums
ClosedPublic
Actions

Authored by PiRK on Jul 8 2025, 13:45.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3430fbdf2349: [electrum] scripted-diff: use some Qt6 enums
Summary
  • QSizePolicy.(\w+) -> QSizePolicy.Policy.$1
  • Qt\.(AlignCenter|AlignHCenter|AlignVCenter|AlignLeft|AlignRight|AlignTop|AlignBottom|AlignJustify|AlignBaseline) -> Qt.AlignmentFlag.$1
  • QLineEdit.Password -> QLineEdit.EchoMode.Password
  • Qt\.(\w+)Focus([^\w]) -> Qt\.FocusPolicy.$1Focus$2

There are a lot more changes required to switch to the Qt6 API, but we don't need to do it all in a single commit thanks to qtpy providing the Qt6 compatibility layer for Qt5
These instances are the ones related to D18338

Depends on D18338

Test Plan
QT_API=pyqt6 ./electrum-abc
QT_API=pyqt5 ./electrum-abc

Diff Detail

Repository
rABC Bitcoin ABC
Branch
trezor_qt6
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33798
Build 67074: Build Diffelectrum-tests · electrum-functional-tests
Build 67073: arc lint + arc unit

Event Timeline

PiRK created this revision.Jul 8 2025, 13:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 8 2025, 13:45
PiRK requested review of this revision.Jul 8 2025, 13:45
PiRK edited the summary of this revision. (Show Details)Jul 8 2025, 13:45
PiRK updated this revision to Diff 54743.Jul 8 2025, 13:49
PiRK edited the summary of this revision. (Show Details)

don't forget AlignRight

Harbormaster completed remote builds in B33797: Diff 54742.Jul 8 2025, 13:51
Harbormaster completed remote builds in B33798: Diff 54743.Jul 8 2025, 13:57
Fabien accepted this revision.Jul 8 2025, 13:59
Fabien added a subscriber: Fabien.
Fabien added inline comments.
electrum/electrumabc_plugins/fusion/qt.py
1965

shouldn't this be removed instead ?

This revision is now accepted and ready to land.Jul 8 2025, 13:59
PiRK updated this revision to Diff 54745.Jul 8 2025, 14:06

remove commented dead code

Harbormaster completed remote builds in B33800: Diff 54745.Jul 8 2025, 14:15
Closed by commit rABC3430fbdf2349: [electrum] scripted-diff: use some Qt6 enums (authored by PiRK). · Explain WhyJul 9 2025, 07:52
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3430fbdf2349: [electrum] scripted-diff: use some Qt6 enums.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc_gui/
qt/
8 lines
6 lines
avalanche/
10 lines
7 lines
28 lines
4 lines
4 lines
6 lines
27 lines
30 lines
8 lines
2 lines
8 lines
qrreader/
4 lines
10 lines
2 lines
5 lines
10 lines
6 lines
4 lines
8 lines
4 lines
utils/
14 lines
electrumabc_plugins/
fusion/
36 lines
hw_wallet/
10 lines
keepkey/
4 lines
ledger/
2 lines
satochip/
22 lines

Diff 54743

View Options

electrum/electrumabc_gui/qt/address_list.py

Loading...
View Options

electrum/electrumabc_gui/qt/amountedit.py

Loading...
View Options

electrum/electrumabc_gui/qt/avalanche/proof_editor.py

Loading...
View Options

electrum/electrumabc_gui/qt/console.py

Loading...
View Options

electrum/electrumabc_gui/qt/external_plugins_window.py

Loading...
View Options

electrum/electrumabc_gui/qt/history_list.py

Loading...
View Options

electrum/electrumabc_gui/qt/installwizard.py

Loading...
View Options

electrum/electrumabc_gui/qt/invoice_dialog.py

Loading...
View Options

electrum/electrumabc_gui/qt/main_window.py

Loading...
View Options

electrum/electrumabc_gui/qt/network_dialog.py

Loading...
View Options

electrum/electrumabc_gui/qt/password_dialog.py

Loading...
View Options

electrum/electrumabc_gui/qt/popup_widget.py

Loading...
View Options

electrum/electrumabc_gui/qt/qrcodewidget.py

Loading...
View Options

electrum/electrumabc_gui/qt/qrreader/camera_dialog.py

Loading...
View Options

electrum/electrumabc_gui/qt/qrwindow.py

Loading...
View Options

electrum/electrumabc_gui/qt/scan_beyond_gap.py

Loading...
View Options

electrum/electrumabc_gui/qt/seed_dialog.py

Loading...
View Options

electrum/electrumabc_gui/qt/settings_dialog.py

Loading...
View Options

electrum/electrumabc_gui/qt/sign_verify_dialog.py

Loading...
View Options

electrum/electrumabc_gui/qt/transaction_dialog.py

Loading...
View Options

electrum/electrumabc_gui/qt/udev_installer.py

Loading...
View Options

electrum/electrumabc_gui/qt/util.py

Loading...
View Options

electrum/electrumabc_gui/qt/utils/aspect_layout.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/qt.py

Loading...
View Options

electrum/electrumabc_plugins/hw_wallet/trezor_qt_pinmatrix.py

Loading...
View Options

electrum/electrumabc_plugins/keepkey/qt.py

Loading...
View Options

electrum/electrumabc_plugins/ledger/qt.py

Loading...
View Options

electrum/electrumabc_plugins/satochip/qt.py

Loading...