Differential D18416

[avalanche] Disconnect from the updated block tip handler before destructing the processor
ClosedPublic
Actions

Authored by Fabien on Jul 25 2025, 12:36.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCe15929b9ed8e: [avalanche] Disconnect from the updated block tip handler before destructing…

Summary

Make sure we can't reach a use after free issue where UpdatedBlockTip() is called after the peer manager has been destructed. This can only happen in tests because the normal node shutdown take cares of this already.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 25 2025, 12:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2025, 12:36

Fabien requested review of this revision.Jul 25 2025, 12:36

@bot build-asan

teamcity awarded a token.Jul 25 2025, 12:37

Harbormaster completed remote builds in B33976: Diff 55003.Jul 25 2025, 12:49

PiRK accepted this revision.Jul 25 2025, 14:57

This revision is now accepted and ready to land.Jul 25 2025, 14:57

Closed by commit rABCe15929b9ed8e: [avalanche] Disconnect from the updated block tip handler before destructing… (authored by Fabien). · Explain WhyJul 26 2025, 08:36

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe15929b9ed8e: [avalanche] Disconnect from the updated block tip handler before destructing….

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.cpp

1 line

Diff 55013

View Options

src/avalanche/processor.cpp

[avalanche] Disconnect from the updated block tip handler before destructing the processorClosedPublicActions