[avalanche][chronik] Bridge the isAvalancheFinalizedPreconsensus method and use it for the tx is_final status
ClosedPublic
Actions

Authored by Fabien on Jul 28 2025, 10:24.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC94cc26c831b4: [avalanche][chronik] Bridge the isAvalancheFinalizedPreconsensus method and use…

Summary

This method makes it possible for chronik to retrieve the finalization status from avalanche pre-consensus for transactions. This means that a tx can be shown as "is_final": true before it is included in a final block.

This is a big enough of a change but it's mostly boilerplate.

Depends on D18419.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 28 2025, 10:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 28 2025, 10:24

Fabien requested review of this revision.Jul 28 2025, 10:24

Harbormaster completed remote builds in B33984: Diff 55015.Jul 28 2025, 10:50

PiRK accepted this revision.Jul 28 2025, 12:28

PiRK added a subscriber: PiRK.

PiRK added inline comments.

chronik/chronik-indexer/src/query/tx_token_data.rs
414 ↗	(On Diff #55015)	unrelated

This revision is now accepted and ready to land.Jul 28 2025, 12:28

tobias_ruck added a subscriber: tobias_ruck.Jul 28 2025, 16:00

tobias_ruck added inline comments.

chronik/chronik-indexer/src/query/util.rs
58 ↗	(On Diff #55015)	I usually add an „is“ or „has“ prefix booleans for clarity, how about `is_preconsensus_finalized` Or `is_final_preconsensus`

Feedback

Harbormaster completed remote builds in B33985: Diff 55017.Jul 29 2025, 07:56

Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.

Tail of the build log:

   Doc-tests chronik_bridge

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_db

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_http

running 1 test
test chronik/chronik-http/src/protobuf.rs - protobuf::Protobuf (line 29) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.36s

   Doc-tests chronik_indexer

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_plugin

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_plugin_common

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_plugin_impl

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_proto

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_util

running 2 tests
test chronik/chronik-util/src/log.rs - log::log (line 65) ... ignored
test chronik/chronik-util/src/log.rs - log::log_chronik (line 87) ... ignored

test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.00s

ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik-plugins failed with exit code 1

Rebase

Harbormaster completed remote builds in B33987: Diff 55019.Jul 29 2025, 09:02

Closed by commit rABC94cc26c831b4: [avalanche][chronik] Bridge the isAvalancheFinalizedPreconsensus method and use… (authored by Fabien). · Explain WhyJul 29 2025, 10:16

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC94cc26c831b4: [avalanche][chronik] Bridge the isAvalancheFinalizedPreconsensus method and use….