Page MenuHomePhabricator
Differential D18486

[Cashtab] Replace zxing with html5-qrscode
ClosedPublic
Actions

Authored by bytesofman on Aug 13 2025, 13:40.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC316ea48bb7b7: [Cashtab] Replace zxing with html5-qrscode
Summary

Follow implementation of scanapp.org, support zoom, improve modal style. Seems to improve scanning behavior.

Test Plan

This is deployed at cashtab.io. Try scanning QR codes. npm test

This QR code in particular:

image.png (664×523 px, 182 KB)

  • cashtab.com struggles to scan it
  • cashtab.io (should) scan it instantly

Diff Detail

Repository
rABC Bitcoin ABC
Branch
html5-qr
Lint
Lint Errors
SeverityLocationCodeMessage
Errorcashtab/src/components/Common/ScanQRCode.tsx:50ESLINT@typescript-eslint/no-unused-vars
Errorcashtab/src/components/Common/ScanQRCode.tsx:135ESLINT@typescript-eslint/no-unused-vars
Unit
No Test Coverage
Build Status
Buildable 34138
Build 67744: Build Diffcashtab-tests
Build 67743: arc lint + arc unit

Event Timeline

bytesofman created this revision.Aug 13 2025, 13:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 13 2025, 13:40
Harbormaster completed remote builds in B34138: Diff 55228.Aug 13 2025, 13:40
teamcity added a comment.Aug 13 2025, 13:40
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  52% (11/21)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  57% (12/21)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  61% (13/21)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  66% (14/21)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  71% (15/21)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  76% (16/21)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  80% (17/21)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  85% (18/21)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  90% (19/21)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  95% (20/21)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 100% (21/21)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 100% (21/21), done.        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:   9% (1/11)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  18% (2/11)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  27% (3/11)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  36% (4/11)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  45% (5/11)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  54% (6/11)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  63% (7/11)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  72% (8/11)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  81% (9/11)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  90% (10/11)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 100% (11/11)        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 100% (11/11), done.        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Total 11 (delta 8), reused 0 (delta 0), pack-reused 0        
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects:   9% (1/11)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  18% (2/11)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  27% (3/11)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  36% (4/11)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  45% (5/11)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  54% (6/11)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  63% (7/11)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  72% (8/11)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  81% (9/11)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  90% (10/11)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 100% (11/11)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 100% (11/11), 3.81 KiB | 3.81 MiB/s, done.
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:   0% (0/8)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:  12% (1/8)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:  25% (2/8)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:  37% (3/8)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:  50% (4/8)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:  62% (5/8)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:  75% (6/8)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:  87% (7/8)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 100% (8/8)
[13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 100% (8/8), completed with 8 local objects.
[13:40:51]i: VCS root 'Bitcoin ABC Staging': From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging
[13:40:51]i: VCS root 'Bitcoin ABC Staging':  * [new tag]               phabricator/base/55228 -> phabricator/base/55228
[13:40:51]i: VCS root 'Bitcoin ABC Staging':  * [new tag]               phabricator/diff/55228 -> phabricator/diff/55228
[13:40:52]i: Done collecting changes for 'Bitcoin ABC Staging': 1 changes collected 1 changes persisted, total time: 5s,684ms, persisting time: 5ms
[13:40:52] : Compute revision for 'Bitcoin ABC Staging'
[13:40:52] :	 [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: 59f3b13fa43de9f9ab98e640859132bb6819b66b
[13:40:52]i:	 [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 84051
[13:40:52] : Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout
[13:40:52] :	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Upper limit revision: 602c7e2af027bb16cc6a4fc5a25601e8c853be5e
[13:40:52]i:	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] MaxModId = 83296
[13:40:52] :	 [Compute revision for 'Bitcoin ABC Staging'] Computed revision: 59f3b13fa43de9f9ab98e640859132bb6819b66b
[13:40:52] :	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Computed revision: 602c7e2af027bb16cc6a4fc5a25601e8c853be5e
[13:40:56]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start
bytesofman updated this revision to Diff 55229.Aug 13 2025, 13:41

lint

Harbormaster completed remote builds in B34139: Diff 55229.Aug 13 2025, 13:42
teamcity added a comment.Aug 13 2025, 13:42
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  52% (11/21)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  57% (12/21)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  61% (13/21)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  66% (14/21)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  71% (15/21)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  76% (16/21)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  80% (17/21)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  85% (18/21)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  90% (19/21)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects:  95% (20/21)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 100% (21/21)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 100% (21/21), done.        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:   9% (1/11)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  18% (2/11)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  27% (3/11)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  36% (4/11)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  45% (5/11)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  54% (6/11)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  63% (7/11)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  72% (8/11)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  81% (9/11)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects:  90% (10/11)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 100% (11/11)        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 100% (11/11), done.        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Total 11 (delta 8), reused 0 (delta 0), pack-reused 0        
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects:   9% (1/11)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  18% (2/11)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  27% (3/11)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  36% (4/11)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  45% (5/11)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  54% (6/11)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  63% (7/11)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  72% (8/11)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  81% (9/11)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects:  90% (10/11)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 100% (11/11)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 100% (11/11), 3.86 KiB | 3.86 MiB/s, done.
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:   0% (0/8)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:  12% (1/8)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:  25% (2/8)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:  37% (3/8)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:  50% (4/8)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:  62% (5/8)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:  75% (6/8)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas:  87% (7/8)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 100% (8/8)
[13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 100% (8/8), completed with 8 local objects.
[13:41:54]i: VCS root 'Bitcoin ABC Staging': From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging
[13:41:54]i: VCS root 'Bitcoin ABC Staging':  * [new tag]               phabricator/base/55229 -> phabricator/base/55229
[13:41:54]i: VCS root 'Bitcoin ABC Staging':  * [new tag]               phabricator/diff/55229 -> phabricator/diff/55229
[13:41:55]i: Done collecting changes for 'Bitcoin ABC Staging': 1 changes collected 1 changes persisted, total time: 5s,726ms, persisting time: 5ms
[13:41:55] : Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout
[13:41:55] :	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Upper limit revision: 602c7e2af027bb16cc6a4fc5a25601e8c853be5e
[13:41:55]i:	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] MaxModId = 83296
[13:41:55] : Compute revision for 'Bitcoin ABC Staging'
[13:41:55] :	 [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: 524e9b5b20abe8631a0b21bc5efb8993622aa245
[13:41:55]i:	 [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 84052
[13:41:55] :	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Computed revision: 602c7e2af027bb16cc6a4fc5a25601e8c853be5e
[13:41:55] :	 [Compute revision for 'Bitcoin ABC Staging'] Computed revision: 524e9b5b20abe8631a0b21bc5efb8993622aa245
[13:42:00]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start
bytesofman updated this revision to Diff 55231.Aug 13 2025, 14:44

default zoom one, comments

Harbormaster completed remote builds in B34141: Diff 55231.Aug 13 2025, 14:49
bytesofman updated this revision to Diff 55235.Aug 13 2025, 15:33

responsive modal sizing

bytesofman edited the test plan for this revision. (Show Details)Aug 13 2025, 15:39
Harbormaster completed remote builds in B34144: Diff 55235.Aug 13 2025, 15:39
bytesofman updated this revision to Diff 55236.Aug 13 2025, 15:50

do not scroll in modal for zoom, overlay it

Harbormaster completed remote builds in B34145: Diff 55236.Aug 13 2025, 16:06
bytesofman published this revision for review.Aug 13 2025, 16:13
Fabien added a subscriber: Fabien.Aug 13 2025, 18:18

@bot preview-cashtab

teamcity awarded a token.Aug 13 2025, 18:18
teamcity added a comment.Aug 13 2025, 18:21

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.91.14.25:41538 for the next 60 minutes.

Fabien accepted this revision.Aug 13 2025, 18:26
This revision is now accepted and ready to land.Aug 13 2025, 18:26
Closed by commit rABC316ea48bb7b7: [Cashtab] Replace zxing with html5-qrscode (authored by bytesofman). · Explain WhyAug 13 2025, 21:41
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC316ea48bb7b7: [Cashtab] Replace zxing with html5-qrscode.

Revision Contents
Changeset List

PathSize
cashtab/
50 lines
2 lines
src/
components/
Common/
260 lines
__tests__/
17 lines

Diff 55228

View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/Common/ScanQRCode.tsx

Loading...
View Options

cashtab/src/components/Common/__tests__/ScanQRCode.test.tsx

Loading...