Page MenuHomePhabricator
Differential D18582

kernel: Move non-kernel db cache size constants
ClosedPublic
Actions

Authored by PiRK on Sep 9 2025, 13:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe43334d98b7c: kernel: Move non-kernel db cache size constants
Summary

These have nothing to do with the txdb, so move them out and into the
node caches.

This is a backport of core#31483
https://github.com/bitcoin/bitcoin/pull/31483/commits/8826cae285490439dc1f19b25fa70b2b9e62dfe8
Depends on D18581

Note: the renaming of constants was already done in D8318. It's a good idea to keep the _MB suffix for now, they will be removed in a later commit when units are converted to bytes.

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 9 2025, 13:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 9 2025, 13:56
PiRK requested review of this revision.Sep 9 2025, 13:56
teamcity edited the summary of this revision. (Show Details)Sep 9 2025, 13:56
PiRK added a child revision: D18583: kernel: Move default cache constants to caches.Sep 9 2025, 13:57
Harbormaster completed remote builds in B34362: Diff 55535.Sep 9 2025, 14:14
teamcity added a comment.Sep 9 2025, 14:14
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[400/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[401/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[402/586] Linking C executable src/secp256k1/ecmult-bench
[403/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[404/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[405/586] Building CXX object src/CMakeFiles/server.dir/rpc/txoutproof.cpp.o
[406/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[407/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[408/586] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[409/586] Building CXX object src/CMakeFiles/server.dir/rpc/mempool.cpp.o
[410/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[411/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[412/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[413/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[414/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[415/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[416/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[417/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[418/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[419/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[420/586] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[421/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[422/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[423/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[424/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[425/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[426/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[427/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[428/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[429/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[430/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[431/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[432/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[433/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[434/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[435/586] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[436/586] Linking CXX static library src/wallet/libwallet.a
[437/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[438/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[439/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[440/586] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[441/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[442/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[443/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[444/586] Linking CXX executable src/iguana/iguana
[445/586] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[446/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[447/586] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[448/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[449/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[450/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[451/586] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[452/586] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[453/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[454/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[455/586] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[456/586] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[457/586] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Sep 9 2025, 14:20
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[399/584] Linking CXX executable src/bitcoin-tx
[400/584] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[401/584] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[402/584] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[403/584] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[404/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[405/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[406/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[407/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[408/584] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[409/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[410/584] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[411/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[412/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[413/584] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[414/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[415/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[416/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[417/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[418/584] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[419/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[420/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[421/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[422/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[423/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[424/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[425/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[426/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[427/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[428/584] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[429/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[430/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[431/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[432/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[433/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[434/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[435/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[436/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[437/584] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[438/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[439/584] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[440/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[441/584] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[442/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[443/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[444/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[445/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[446/584] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[447/584] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[448/584] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[449/584] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[450/584] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[451/584] Linking CXX executable src/iguana/iguana
[452/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[453/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[454/584] Linking CXX static library src/wallet/libwallet.a
[455/584] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[456/584] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
PiRK planned changes to this revision.Sep 9 2025, 14:21

needs rebase after D18581 is fixed

PiRK updated this revision to Diff 55556.Sep 10 2025, 06:31

rebase

Harbormaster completed remote builds in B34378: Diff 55556.Sep 10 2025, 06:47
Fabien accepted this revision.Sep 10 2025, 09:23
This revision is now accepted and ready to land.Sep 10 2025, 09:23
PiRK updated this revision to Diff 55560.Sep 10 2025, 10:04

keep the cstdint header for now, it will be used in D18583 and removed in D18584

Harbormaster completed remote builds in B34382: Diff 55560.Sep 10 2025, 10:19
Closed by commit rABCe43334d98b7c: kernel: Move non-kernel db cache size constants (authored by TheCharlatan <seb.kung@gmail.com>, committed by PiRK). · Explain WhySep 10 2025, 14:58
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe43334d98b7c: kernel: Move non-kernel db cache size constants.

Revision Contents
Changeset List

PathSize
src/
node/
4 lines
8 lines
7 lines

Diff 55575

View Options

src/node/caches.h

Loading...
View Options

src/node/caches.cpp

Loading...
View Options

src/txdb.h

Loading...