[test] factor some common block generation code in functional tests
ClosedPublic
Actions

Authored by PiRK on Sep 30 2025, 12:47.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc7ce6566f059: [test] factor some common block generation code in functional tests

Summary

This will make it easier to fix the update_block method in a single place in a following commit

These helper methods only differ by a few lines: feature_block has a custom key to sign the coinbase transactions, abc-mempool-coherence-on-activation sets a specific time for the first block. This is solved by adding an extra generate_coinbase_key method and adding an optional coinbase_time argument to next_block

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 30 2025, 12:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2025, 12:47

PiRK requested review of this revision.Sep 30 2025, 12:47

PiRK added inline comments.Sep 30 2025, 12:51

test/functional/abc-replay-protection.py
153 ↗	(On Diff #56000)	i kept the move_tip method name used by feature_block to keep the diff minimal. Renaming self.move_tip to self.set_tip in `feature_block` would have been more lines to modify, and could potentially make future Core backports slightly more conflict prone.