Page MenuHomePhabricator
Differential D18782

[electrum] fix save QR code feature
ClosedPublic
Actions

Authored by PiRK on Oct 10 2025, 10:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC83ed6e9da2c7: [electrum] fix save QR code feature
Summary

This was broken in D14538 when ElectrumWindow.static_getOpenFileName was removed

fixes https://github.com/Bitcoin-ABC/bitcoin-abc/issues/589

Depends on D18781

Test Plan

in the receive tab, right click on the QR code, click Save to file

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 10 2025, 10:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2025, 10:10
PiRK requested review of this revision.Oct 10 2025, 10:10
PiRK added inline comments.Oct 10 2025, 10:41
electrum/electrumabc_gui/qt/qrcodewidget.py
120 ↗(On Diff #56130)

this was broken even before D14538.

PiRK added inline comments.Oct 10 2025, 10:42
electrum/electrumabc_gui/qt/qrcodewidget.py
120 ↗(On Diff #56130)

D14094

Harbormaster completed remote builds in B34752: Diff 56130.Oct 10 2025, 11:12
teamcity added a comment.Oct 10 2025, 11:12
Build Bitcoin ABC Diffs / Diff Testing (electrum-functional-tests) failed.

Tail of the build log:

[274/333] Building CXX object src/CMakeFiles/server.dir/policy/block/stakingrewards.cpp.o
[275/333] Building CXX object src/CMakeFiles/server.dir/rpc/abc.cpp.o
[276/333] Building CXX object src/CMakeFiles/server.dir/node/ui_interface.cpp.o
[277/333] Building CXX object src/CMakeFiles/server.dir/rpc/server_util.cpp.o
[278/333] Building CXX object src/CMakeFiles/server.dir/rest.cpp.o
[279/333] Building CXX object src/CMakeFiles/server.dir/script/sigcache.cpp.o
[280/333] Building CXX object src/CMakeFiles/server.dir/script/scriptcache.cpp.o
[281/333] Building CXX object src/CMakeFiles/server.dir/shutdown.cpp.o
[282/333] Building CXX object src/CMakeFiles/server.dir/rpc/txoutproof.cpp.o
[283/333] Building CXX object src/CMakeFiles/server.dir/rpc/mempool.cpp.o
[284/333] Building CXX object src/CMakeFiles/server.dir/timedata.cpp.o
[285/333] Building CXX object src/CMakeFiles/server.dir/rpc/server.cpp.o
[286/333] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[287/333] Building CXX object src/CMakeFiles/server.dir/versionbits.cpp.o
[288/333] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[289/333] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[290/333] Building CXX object src/CMakeFiles/server.dir/txpool.cpp.o
[291/333] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[292/333] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[293/333] Linking C static library src/secp256k1/libsecp256k1.a
[294/333] Linking CXX static library src/libbitcoinconsensus.a
[295/333] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[296/333] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[297/333] Linking CXX static library src/libscript.a
[298/333] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[299/333] Linking CXX static library src/libcommon.a
[300/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[301/333] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[302/333] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[303/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[304/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[305/333] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[306/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[307/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[308/333] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[309/333] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[310/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[311/333] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[312/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[313/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[314/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[315/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[316/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[317/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[318/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[319/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[320/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[321/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[322/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[323/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[324/333] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[325/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[326/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[327/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[328/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[329/333] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[330/333] Linking CXX static library src/wallet/libwallet.a
[331/333] Linking CXX static library src/libserver.a
[332/333] Linking CXX executable src/bitcoind
Build electrum-functional-tests timed out after 3600.0s
PiRK planned changes to this revision.Oct 10 2025, 15:40
PiRK updated this revision to Diff 56144.Oct 13 2025, 09:42

rebase

Harbormaster completed remote builds in B34761: Diff 56144.Oct 13 2025, 10:09
Fabien accepted this revision.Oct 13 2025, 13:04
Fabien edited the summary of this revision. (Show Details)
Fabien added a parent revision: D18781: [electrum] deglobalize config.
Fabien removed a parent revision: D17781: [chronik] Bump corrosion to 0.5.1.
This revision is now accepted and ready to land.Oct 13 2025, 13:06
Closed by commit rABC83ed6e9da2c7: [electrum] fix save QR code feature (authored by PiRK). · Explain WhyOct 13 2025, 18:28
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC83ed6e9da2c7: [electrum] fix save QR code feature.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc_gui/
qt/
2 lines
12 lines
6 lines

Diff 56155

View Options

electrum/electrumabc_gui/qt/main_window.py

Loading...
View Options

electrum/electrumabc_gui/qt/qrcodewidget.py

Loading...
View Options

electrum/electrumabc_gui/qt/qrwindow.py

Loading...