[ecash-agora] Support for ALP relist
ClosedPublic
Actions

Authored by bytesofman on Wed, Oct 29, 02:45.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC637bad430185: [ecash-agora] Support for ALP relist

Summary

Add a new relist method to AgoraOffer. This is useful for updating the terms of an existing offer without canceling it in one tx and then recreating it in another tx. For example, this method would be useful in updating the price of an existing offer.

Test Plan

npm test, CI test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

agora-relist

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34898
Build 69258: Build Diff	cashtab-tests · ecash-agora-integration-tests · ecash-agora-tests
Build 69257: arc lint + arc unit

Event Timeline

bytesofman created this revision.Wed, Oct 29, 02:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Oct 29, 02:45

Harbormaster completed remote builds in B34898: Diff 56344.Wed, Oct 29, 02:53

bytesofman published this revision for review.Wed, Oct 29, 03:33

PiRK accepted this revision.Wed, Oct 29, 15:54

This revision is now accepted and ready to land.Wed, Oct 29, 15:54

rebase

bytesofman edited the summary of this revision. (Show Details)Wed, Oct 29, 16:08

bytesofman removed a parent revision: D18846: [ecash-agora] Patch CI tests by better organizing test wallet sats.

Harbormaster completed remote builds in B34903: Diff 56351.Wed, Oct 29, 16:11

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: <Token /> available actions rendered We can send an SLP1 NFT ======
Error: expect(element).toBeChecked()

Received element is not checked:
  <input class="sc-hGoxap bNvNmn" id="Toggle Sell NFT" name="Toggle Sell NFT" title="Toggle Sell NFT" type="checkbox" />
    at Object.toBeChecked (/work/cashtab/src/components/Etokens/__tests__/TokenActions.test.js:1042:34)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:549:9)
    at processTimers (node:internal/timers:523:7)

Each failure log is accessible here:
CashTab Unit Tests: <Token /> available actions rendered We can send an SLP1 NFT

Closed by commit rABC637bad430185: [ecash-agora] Support for ALP relist (authored by bytesofman). · Explain WhyWed, Oct 29, 17:08

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC637bad430185: [ecash-agora] Support for ALP relist.