Differential D18874
refactor: Replace GetTimeMicros by SystemClock Authored by Fabien on Wed, Nov 5, 13:34. Tags None Subscribers None
Details
It is unclear from the name that GetTimeMicros returns the system time. Also, it is not using the type-safe std::chrono types. Fix both issues by replacing it with SystemClock in the only place it is used. This refactor should not change behavior. Backport of core#27233. Depends on D18873. ninja all check-all
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Tail of the build log: ^ 1 error generated. [401/585] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o [402/585] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o [403/585] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o [404/585] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o [405/585] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o [406/585] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o [407/585] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o [408/585] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o [409/585] Linking CXX executable src/bitcoin-cli [410/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o [411/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o [412/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o [413/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o [414/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o [415/585] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o [416/585] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o [417/585] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o [418/585] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o [419/585] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o [420/585] Linking CXX executable src/bitcoin-tx [421/585] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o [422/585] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o [423/585] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o [424/585] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o [425/585] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o [426/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o [427/585] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o [428/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o [429/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o [430/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o [431/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o [432/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o [433/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o [434/585] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o [435/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o [436/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o [437/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o [438/585] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o [439/585] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o [440/585] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o [441/585] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o [442/585] Linking CXX executable src/iguana/iguana [443/585] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o [444/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o [445/585] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o [446/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o [447/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o [448/585] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o [449/585] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o [450/585] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o [451/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o [452/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o [453/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o [454/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o [455/585] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o [456/585] Linking CXX static library src/wallet/libwallet.a ninja: build stopped: cannot make progress due to previous errors. Build build-clang failed with exit code 1 Comment Actions Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Tail of the build log: 1 warning treated as error [411/595] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o [412/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o [413/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o [414/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o [415/595] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o [416/595] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o [417/595] Linking CXX executable src/bitcoin-cli [418/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o [419/595] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o [420/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o [421/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o [422/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o [423/595] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o [424/595] Linking CXX executable src/bitcoin-tx [425/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o [426/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o [427/595] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o [428/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o [429/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o [430/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o [431/595] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o [432/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o [433/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o [434/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o [435/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o [436/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o [437/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o [438/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o [439/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o [440/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o [441/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o [442/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o [443/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o [444/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o [445/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o [446/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o [447/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o [448/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o [449/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o [450/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o [451/595] Linking CXX static library chronik/libchronik-bridge.a [452/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o [453/595] Linking CXX static library chronik/libchronik.a [454/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o [455/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o [456/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o [457/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o [458/595] Linking CXX executable src/iguana/iguana [459/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o [460/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o [461/595] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o [462/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o [463/595] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o [464/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o [465/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o [466/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o [467/595] Linking CXX static library src/wallet/libwallet.a ninja: build stopped: cannot make progress due to previous errors. Build build-clang-tidy failed with exit code 1 |