guix: move *-check.py scripts under contrib/guix
ClosedPublic
Actions

Authored by PiRK on Fri, Nov 7, 09:05.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4c287f0d5abb: guix: move *-check.py scripts under contrib/guix

Summary

These scripts are not meant for general developer usage. They are for
use on the release binaries, which have been compiled in an environment
that makes various assumptions in regards to c library, compiler
options, hardening options, patching etc.

This is a backport of core#32458

Depends on D18898

Note that I need to disable linters for this diff because the current required version of lief (0.13.2) cannot be installed with python 3.12, and the next available version break the API so the mypy linter fails.
This diff is a step towards fixing this, and make it possible again to run arc lint --everything with python >= 3.12, because it is a dependency of the PR that bumps the lief version.

Test Plan

guix builds

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Fri, Nov 7, 09:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 7, 09:05

teamcity edited the summary of this revision. (Show Details)Fri, Nov 7, 09:05

@bot guix-linux guix-osx guix-win

teamcity awarded a token.Fri, Nov 7, 09:07

Harbormaster completed remote builds in B35005: Diff 56505.Fri, Nov 7, 09:30

PiRK added a child revision: D18900: deps: bump lief to 0.16.6.Fri, Nov 7, 09:43

PiRK published this revision for review.Fri, Nov 7, 12:57

why did you skip the linter ?

In D18899#430955, @Fabien wrote:

why did you skip the linter ?

As mentioned in the summary, this is a step for fixing the linter with python 3.12 (the fix is in the next diff).
It would fail because these script rely heavily on lief==0.13.2, and this version cannot be installed with python 3.12 because there is no wheel on pypi, and compilation from sources is far from trivial. So at the moment if you install any supported version of lief with python 3.12, mypy returns errors because the API of the library changed in newer version.

Fabien accepted this revision.Fri, Nov 7, 14:08

This revision is now accepted and ready to land.Fri, Nov 7, 14:08

Closed by commit rABC4c287f0d5abb: guix: move *-check.py scripts under contrib/guix (authored by fanquake <fanquake@gmail.com>, committed by PiRK). · Explain WhyFri, Nov 7, 14:37

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4c287f0d5abb: guix: move *-check.py scripts under contrib/guix.