Paths

Table of Contentst

Differential D18912

[lint] add a blank line after module level docstring in python files
ClosedPublic
Actions

Authored by PiRK on Mon, Nov 10, 07:54.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb4ec750c43d7: [lint] add a blank line after module level docstring in python files

Summary

This is extracted out of D18904.

I used the search and replace tool in my IDE with the following regex:
^("""(?:\\[\s\S]|[^"\\]|"(?!"")|""(?!"))*""")\r?\n(\w)

Replaced by
$1\n\n$2

A few false positives had to be filtered out, so this is not really a scripted diff.

Depends on D18903

Test Plan

Trivial self-review, and a run of all python tests just to be sure.
ninja all check-all check-electrum check-electrum-functional`

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35025
Build 69511: Build Diff	electrum-tests · build-without-wallet · build-debug · electrum-functional-tests · build-clang · build-clang-tidy · build-diff
Build 69510: arc lint + arc unit

Event Timeline

PiRK created this revision.Mon, Nov 10, 07:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 10, 07:54

newline nit

PiRK added a child revision: D18904: [lint] switch from Black to Ruff for python code formatting.Mon, Nov 10, 07:59

Harbormaster completed remote builds in B35025: Diff 56533.Mon, Nov 10, 08:24

Harbormaster completed remote builds in B35026: Diff 56534.

i forgot to publish that one, it is a dependency for the black -> ruff diff

Fabien accepted this revision.Mon, Nov 10, 12:52

This revision is now accepted and ready to land.Mon, Nov 10, 12:52

Closed by commit rABCb4ec750c43d7: [lint] add a blank line after module level docstring in python files (authored by PiRK). · Explain WhyMon, Nov 10, 15:27

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCb4ec750c43d7: [lint] add a blank line after module level docstring in python files.

Revision Contents
Changeset List

Path

Size

contrib/

devtools/

optimize-pngs.py

1 line

update-translations.py

1 line

utils.py

1 line

guix/

security-check.py

1 line

symbol-check.py

1 line

testgen/

base58.py

1 line

gen_base58_test_vectors.py

1 line

electrum/

electrum-abc

2 lines

electrumabc/

avalanche/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

tests/

regtest/

test_reorg.py

1 line

electrumabc_plugins/

fusion/

1 line

1 line

1 line

1 line

test/

functional/

abc_feature_persist_avapeers.py

1 line

abc_feature_persist_headers_time.py

1 line

abc_feature_preconsensus_activation.py

1 line

abc_feature_staking_preconsensus_activation.py

1 line

abc_mining_avalanche_preconsensus.py

1 line

abc_p2p_avalanche_contender_voting.py

1 line

abc_p2p_avalanche_cooldown.py

1 line

abc_p2p_avalanche_policy_minerfund.py

1 line

abc_p2p_avalanche_policy_rtt.py

1 line

abc_p2p_avalanche_policy_stakingrewards.py

1 line

abc_p2p_avalanche_proof_voting.py

1 line

abc_p2p_avalanche_remote_proofs.py

1 line

abc_p2p_avalanche_transaction_voting.py

1 line

abc_p2p_avalanche_voting.py

1 line

abc_p2p_getavaaddr.py

1 line

abc_rpc_avalancheproof.py

1 line

abc_rpc_finalizetransaction.py

1 line

abc_rpc_getavalancheinfo.py

1 line

abc_rpc_getavalanchepeerinfo.py

1 line

abc_rpc_getavalancheproofs.py

1 line

abc_rpc_isfinal.py

1 line

chronik_electrum_basic.py

1 line

chronik_electrum_blockchain.py

1 line

chronik_ws.py

1 line

chronik_ws_avalanche.py

1 line

data/

invalid_txs.py

1 line

feature_asmap.py

1 line

feature_assumeutxo.py

1 line

feature_block.py

1 line

feature_config_args.py

1 line

feature_fastprune.py

1 line

feature_filelock.py

1 line

feature_includeconf.py

1 line

feature_index_prune.py

1 line

feature_init.py

1 line

feature_notifications.py

1 line

interface_zmq.py

1 line

mempool_persist.py

1 line

mempool_updatefromblock.py

1 line

p2p_disconnect_ban.py

1 line

p2p_eviction.py

1 line

p2p_getdata.py

1 line

p2p_node_network_limited.py

1 line

p2p_sendheaders.py

1 line

p2p_tx_privacy.py

1 line

rpc_createmultisig.py

1 line

rpc_deriveaddresses.py

1 line

1 line

1 line

1 line

1 line

test_framework/

messages.py

1 line

wallet_util.py

1 line

wallet_abandonconflict.py

1 line

1 line

1 line

1 line

1 line

1 line

wallet_keypool_topup.py

1 line

wallet_labels.py

1 line

wallet_multiwallet.py

1 line

wallet_pruning.py

1 line

wallet_resendwallettransactions.py

1 line

wallet_startup.py

1 line

wallet_txn_doublespend.py

1 line

Diff 56533

View Options

contrib/devtools/optimize-pngs.py

View Options

contrib/devtools/update-translations.py

View Options

contrib/devtools/utils.py

View Options

contrib/guix/security-check.py

View Options

contrib/guix/symbol-check.py

View Options

contrib/testgen/base58.py

View Options

contrib/testgen/gen_base58_test_vectors.py

View Options

electrum/electrum-abc

View Options

electrum/electrumabc/avalanche/delegation.py

View Options

electrum/electrumabc/avalanche/primitives.py

View Options

electrum/electrumabc/avalanche/proof.py

View Options

electrum/electrumabc/consolidate.py

View Options

electrum/electrumabc/schnorr.py

View Options

electrum/electrumabc/secp256k1.py

View Options

electrum/electrumabc/serialize.py

View Options

electrum/electrumabc/tests/regtest/test_reorg.py

View Options

electrum/electrumabc_plugins/fusion/comms.py

View Options

electrum/electrumabc_plugins/fusion/conf.py

View Options

electrum/electrumabc_plugins/fusion/fusion_pb2.py

View Options

electrum/electrumabc_plugins/fusion/plugin.py

View Options

test/functional/abc_feature_persist_avapeers.py

View Options

test/functional/abc_feature_persist_headers_time.py

View Options

test/functional/abc_feature_preconsensus_activation.py

View Options

test/functional/abc_feature_staking_preconsensus_activation.py

View Options

test/functional/abc_mining_avalanche_preconsensus.py

View Options

test/functional/abc_p2p_avalanche_contender_voting.py

View Options

test/functional/abc_p2p_avalanche_cooldown.py

View Options

test/functional/abc_p2p_avalanche_policy_minerfund.py

View Options

test/functional/abc_p2p_avalanche_policy_rtt.py

View Options

test/functional/abc_p2p_avalanche_policy_stakingrewards.py

View Options

test/functional/abc_p2p_avalanche_proof_voting.py

View Options

test/functional/abc_p2p_avalanche_remote_proofs.py

View Options

test/functional/abc_p2p_avalanche_transaction_voting.py

View Options

test/functional/abc_p2p_avalanche_voting.py

View Options

test/functional/abc_p2p_getavaaddr.py

View Options

test/functional/abc_rpc_avalancheproof.py

View Options

test/functional/abc_rpc_finalizetransaction.py

View Options

test/functional/abc_rpc_getavalancheinfo.py

View Options

test/functional/abc_rpc_getavalanchepeerinfo.py

View Options

test/functional/abc_rpc_getavalancheproofs.py

View Options

test/functional/abc_rpc_isfinal.py

View Options

test/functional/chronik_electrum_basic.py

View Options

test/functional/chronik_electrum_blockchain.py

View Options

test/functional/chronik_ws.py

View Options

test/functional/chronik_ws_avalanche.py

View Options

test/functional/data/invalid_txs.py

View Options

test/functional/feature_asmap.py

View Options

test/functional/feature_assumeutxo.py

View Options

test/functional/feature_block.py

View Options

test/functional/feature_config_args.py

View Options

test/functional/feature_fastprune.py

View Options

test/functional/feature_filelock.py

View Options

test/functional/feature_includeconf.py

View Options

test/functional/feature_index_prune.py

View Options

test/functional/feature_init.py

View Options

test/functional/feature_notifications.py

View Options

test/functional/interface_zmq.py

View Options

test/functional/mempool_persist.py

View Options

test/functional/mempool_updatefromblock.py

View Options

test/functional/p2p_disconnect_ban.py

View Options

test/functional/p2p_eviction.py

View Options

test/functional/p2p_getdata.py

View Options

test/functional/p2p_node_network_limited.py

View Options

test/functional/p2p_sendheaders.py

View Options

test/functional/p2p_tx_privacy.py

View Options

test/functional/rpc_createmultisig.py

View Options

test/functional/rpc_deriveaddresses.py

View Options

test/functional/rpc_dumptxoutset.py

View Options

test/functional/rpc_misc.py

View Options

test/functional/rpc_scantxoutset.py

View Options

test/functional/rpc_whitelist.py

View Options

test/functional/test_framework/messages.py

View Options

test/functional/test_framework/wallet_util.py

View Options

test/functional/wallet_abandonconflict.py

View Options

test/functional/wallet_assumeutxo.py

View Options

test/functional/wallet_backup.py

View Options

test/functional/wallet_balance.py

View Options

test/functional/wallet_basic.py

View Options

test/functional/wallet_keypool.py

View Options

test/functional/wallet_keypool_topup.py

View Options

test/functional/wallet_labels.py

View Options

test/functional/wallet_multiwallet.py

View Options

test/functional/wallet_pruning.py

View Options

test/functional/wallet_resendwallettransactions.py

View Options

test/functional/wallet_startup.py

View Options

test/functional/wallet_txn_doublespend.py

[lint] add a blank line after module level docstring in python filesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 56533

contrib/devtools/optimize-pngs.py

contrib/devtools/update-translations.py

contrib/devtools/utils.py

contrib/guix/security-check.py

contrib/guix/symbol-check.py

contrib/testgen/base58.py

contrib/testgen/gen_base58_test_vectors.py

electrum/electrum-abc

electrum/electrumabc/avalanche/delegation.py

electrum/electrumabc/avalanche/primitives.py

electrum/electrumabc/avalanche/proof.py

electrum/electrumabc/consolidate.py

electrum/electrumabc/schnorr.py

electrum/electrumabc/secp256k1.py

electrum/electrumabc/serialize.py

electrum/electrumabc/tests/regtest/test_reorg.py

electrum/electrumabc_plugins/fusion/comms.py

electrum/electrumabc_plugins/fusion/conf.py

electrum/electrumabc_plugins/fusion/fusion_pb2.py

electrum/electrumabc_plugins/fusion/plugin.py

test/functional/abc_feature_persist_avapeers.py

test/functional/abc_feature_persist_headers_time.py

test/functional/abc_feature_preconsensus_activation.py

test/functional/abc_feature_staking_preconsensus_activation.py

test/functional/abc_mining_avalanche_preconsensus.py

test/functional/abc_p2p_avalanche_contender_voting.py

test/functional/abc_p2p_avalanche_cooldown.py

test/functional/abc_p2p_avalanche_policy_minerfund.py

test/functional/abc_p2p_avalanche_policy_rtt.py

test/functional/abc_p2p_avalanche_policy_stakingrewards.py

test/functional/abc_p2p_avalanche_proof_voting.py

test/functional/abc_p2p_avalanche_remote_proofs.py

test/functional/abc_p2p_avalanche_transaction_voting.py

test/functional/abc_p2p_avalanche_voting.py

test/functional/abc_p2p_getavaaddr.py

test/functional/abc_rpc_avalancheproof.py

test/functional/abc_rpc_finalizetransaction.py

test/functional/abc_rpc_getavalancheinfo.py

test/functional/abc_rpc_getavalanchepeerinfo.py

test/functional/abc_rpc_getavalancheproofs.py

test/functional/abc_rpc_isfinal.py

test/functional/chronik_electrum_basic.py

test/functional/chronik_electrum_blockchain.py

test/functional/chronik_ws.py

test/functional/chronik_ws_avalanche.py

test/functional/data/invalid_txs.py

test/functional/feature_asmap.py

test/functional/feature_assumeutxo.py

test/functional/feature_block.py

test/functional/feature_config_args.py

test/functional/feature_fastprune.py

test/functional/feature_filelock.py

test/functional/feature_includeconf.py

test/functional/feature_index_prune.py

test/functional/feature_init.py

test/functional/feature_notifications.py

test/functional/interface_zmq.py

test/functional/mempool_persist.py

test/functional/mempool_updatefromblock.py

test/functional/p2p_disconnect_ban.py

test/functional/p2p_eviction.py

test/functional/p2p_getdata.py

test/functional/p2p_node_network_limited.py

test/functional/p2p_sendheaders.py

test/functional/p2p_tx_privacy.py

test/functional/rpc_createmultisig.py

test/functional/rpc_deriveaddresses.py

test/functional/rpc_dumptxoutset.py

test/functional/rpc_misc.py

test/functional/rpc_scantxoutset.py

test/functional/rpc_whitelist.py

test/functional/test_framework/messages.py

test/functional/test_framework/wallet_util.py

test/functional/wallet_abandonconflict.py

[lint] add a blank line after module level docstring in python files
ClosedPublic
Actions

Revision Contents
Changeset List