Differential D19014

[avalanche] Make the processor's staking preconsensus flag atomic
ClosedPublic
Actions

Authored by Fabien on Tue, Dec 2, 12:47.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC628626bf44eb: [avalanche] Make the processor's staking preconsensus flag atomic

Summary

This should fix a concurrent access issue in the processor tests which triggers TSAN.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_processor_atomic_stakingpreconsensus_flag

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35183
Build 69824: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 69823: arc lint + arc unit

Event Timeline

Fabien created this revision.Tue, Dec 2, 12:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Dec 2, 12:47

Fabien requested review of this revision.Tue, Dec 2, 12:47

@bot build-tsan

teamcity awarded a token.Tue, Dec 2, 12:47

Harbormaster completed remote builds in B35183: Diff 56796.Tue, Dec 2, 13:09

PiRK accepted this revision.Tue, Dec 2, 13:35

This revision is now accepted and ready to land.Tue, Dec 2, 13:35

Closed by commit rABC628626bf44eb: [avalanche] Make the processor's staking preconsensus flag atomic (authored by Fabien). · Explain WhyTue, Dec 2, 14:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC628626bf44eb: [avalanche] Make the processor's staking preconsensus flag atomic.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.h

2 lines

Diff 56796

View Options

[avalanche] Make the processor's staking preconsensus flag atomicClosedPublicActions