crypto: remove outdated variant of ChaCha20Poly1305 AEAD
Needs ReviewPublic
Actions

Authored by PiRK on Tue, Dec 2, 14:44.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Remove the variant of ChaCha20Poly1305 AEAD that was previously added in
anticipation of BIP324 using it. BIP324 was updated to instead use rekeying
wrappers around otherwise unmodified versions of the ChaCha20 stream cipher
and the ChaCha20Poly1305 AEAD as specified in RFC8439.

This is a partial backport of core#28008
https://github.com/bitcoin/bitcoin/pull/28008/commits/9fd085a1a49d317abcaf1492b71c48bf1a1b3007
Depends on D19016

Test Plan

ninja all check-all bench-bitcoin bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35187
Build 69832: Build Diff	lint-circular-dependencies · build-without-wallet · build-fuzzer · build-diff · build-debug · build-clang-tidy · build-clang · build-bench
Build 69831: arc lint + arc unit

Event Timeline

PiRK created this revision.Tue, Dec 2, 14:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Dec 2, 14:44

PiRK requested review of this revision.Tue, Dec 2, 14:44

teamcity edited the summary of this revision. (Show Details)Tue, Dec 2, 14:44

The plan is to backport most of core#28008, except the last two commits (bip324.{h|cpp}) which depend on unbackported secp256k1 cryptography. This way we can then backport core#28100 completely (dependency for random.h).

PiRK added a child revision: D19018: crypto: add the ChaCha20Poly1305 AEAD as specified in RFC8439.Tue, Dec 2, 14:47

Harbormaster completed remote builds in B35187: Diff 56800.Tue, Dec 2, 15:07