Page MenuHomePhabricator
Differential D19074

random: move XoRoShiRo128PlusPlus into random module
ClosedPublic
Actions

Authored by PiRK on Dec 8 2025, 16:25.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe8a39df59817: random: move XoRoShiRo128PlusPlus into random module
Summary

This is preparation for making it more generally accessible.

This is a partial backport of core#29625
https://github.com/bitcoin/bitcoin/pull/29625/commits/8cc2f45065fc1864f879248d1e1444588e27076b
Depends on D19073

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 8 2025, 16:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 8 2025, 16:25
PiRK requested review of this revision.Dec 8 2025, 16:25
teamcity edited the summary of this revision. (Show Details)Dec 8 2025, 16:25
PiRK updated this revision to Diff 56954.Dec 8 2025, 16:26

fix an indentation in adjacent line in src/tests/CMakeLists.txt, while we are touching this

PiRK added inline comments.Dec 8 2025, 16:28
src/test/CMakeLists.txt
261 ↗(On Diff #56954)

i guess it's good that phab uses the weird 2 spaces convention to show tabs, because otherwise I would never have noticed this

Harbormaster completed remote builds in B35292: Diff 56953.Dec 8 2025, 16:35
teamcity added a comment.Dec 8 2025, 16:35
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

FAILED: src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-clang/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-clang/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o -c /work/src/seeder/options.cpp
In file included from /work/src/seeder/options.cpp:7:
In file included from /work/src/./chainparams.h:9:
In file included from /work/src/./kernel/chainparams.h:10:
In file included from /work/src/./netaddress.h:15:
/work/src/./random.h:420:38: error: no member named 'rotl' in namespace 'std'
        const uint64_t result = std::rotl(s0 + s1, 17) + s0;
                                ~~~~~^
/work/src/./random.h:422:21: error: no member named 'rotl' in namespace 'std'
        m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
               ~~~~~^
/work/src/./random.h:423:21: error: no member named 'rotl' in namespace 'std'
        m_s1 = std::rotl(s1, 28);
               ~~~~~^
3 errors generated.
[439/588] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[440/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[441/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[442/588] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
FAILED: src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-clang/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-clang/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o -MF src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o.d -o src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o -c /work/src/wallet/wallettool.cpp
In file included from /work/src/wallet/wallettool.cpp:5:
In file included from /work/src/./chainparams.h:9:
In file included from /work/src/./kernel/chainparams.h:10:
In file included from /work/src/./netaddress.h:15:
/work/src/./random.h:420:38: error: no member named 'rotl' in namespace 'std'
        const uint64_t result = std::rotl(s0 + s1, 17) + s0;
                                ~~~~~^
/work/src/./random.h:422:21: error: no member named 'rotl' in namespace 'std'
        m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
               ~~~~~^
/work/src/./random.h:423:21: error: no member named 'rotl' in namespace 'std'
        m_s1 = std::rotl(s1, 28);
               ~~~~~^
3 errors generated.
[443/588] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-clang/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-clang/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -c /work/src/seeder/bitcoin.cpp
In file included from /work/src/seeder/bitcoin.cpp:5:
In file included from /work/src/./seeder/bitcoin.h:8:
In file included from /work/src/./chainparams.h:9:
In file included from /work/src/./kernel/chainparams.h:10:
In file included from /work/src/./netaddress.h:15:
/work/src/./random.h:420:38: error: no member named 'rotl' in namespace 'std'
        const uint64_t result = std::rotl(s0 + s1, 17) + s0;
                                ~~~~~^
/work/src/./random.h:422:21: error: no member named 'rotl' in namespace 'std'
        m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
               ~~~~~^
/work/src/./random.h:423:21: error: no member named 'rotl' in namespace 'std'
        m_s1 = std::rotl(s1, 28);
               ~~~~~^
3 errors generated.
[444/588] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[445/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[446/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[447/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Dec 8 2025, 16:37
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

      |                     ^~~~
[440/588] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-debug/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-debug/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o -c /work/src/seeder/options.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/seeder/options.cpp:7:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[441/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[442/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[443/588] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
FAILED: src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-debug/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-debug/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o -MF src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o.d -o src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o -c /work/src/wallet/wallettool.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/wallet/wallettool.cpp:5:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[444/588] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-debug/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-debug/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -c /work/src/seeder/bitcoin.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/./seeder/bitcoin.h:8,
                 from /work/src/seeder/bitcoin.cpp:5:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[445/588] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[446/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[447/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Dec 8 2025, 16:38
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

Error while processing /work/src/networks/abc/checkpoints.cpp.
Suppressed 2053 warnings (2053 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).
[256/598] Building CXX object src/CMakeFiles/common.dir/psbt.cpp.o
[257/598] Building CXX object src/CMakeFiles/script.dir/script/script.cpp.o
[258/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/arith_uint256.cpp.o
[259/598] Building CXX object src/CMakeFiles/common.dir/core_write.cpp.o
[260/598] Building CXX object src/CMakeFiles/common.dir/rpc/request.cpp.o
[261/598] Building CXX object src/CMakeFiles/script.dir/script/sigencoding.cpp.o
[262/598] Building CXX object src/CMakeFiles/script.dir/script/interpreter.cpp.o
[263/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/hash.cpp.o
[264/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/uint256.cpp.o
[265/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[266/598] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o
[267/598] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[268/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[269/598] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[270/598] Linking C static library src/secp256k1/libsecp256k1.a
[271/598] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[272/598] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[273/598] Linking C executable src/secp256k1/recover-bench
[274/598] Linking C executable src/secp256k1/sign-bench
[275/598] Linking C executable src/secp256k1/verify-bench
[276/598] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[277/598] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[278/598] Linking C executable src/secp256k1/internal-bench
[279/598] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[280/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[281/598] Linking C executable src/secp256k1/ecmult-bench
[282/598] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[283/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/amount.cpp.o
[284/598] Building CXX object src/CMakeFiles/bitcoinconsensus-shared.dir/script/bitcoinconsensus.cpp.o
[285/598] Building CXX object src/CMakeFiles/common.dir/rpc/rawtransaction_util.cpp.o
[286/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[287/598] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[288/598] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[289/598] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[290/598] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[291/598] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
FAILED: src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o 
/usr/bin/cmake -E __run_co_compile --launcher=/usr/bin/ccache --tidy="/usr/bin/clang-tidy-16;-warnings-as-errors=*;--extra-arg-before=--driver-mode=g++" --source=/work/src/bitcoin-tx.cpp -- /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I/work/src/. -I/work/abc-ci-builds/build-clang-tidy/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-clang-tidy/src/crypto/.. -I/work/src/secp256k1/include -isystem /usr/include/jemalloc -g -O2 -fPIE -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o -MF src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o.d -o src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o -c /work/src/bitcoin-tx.cpp
/work/src/./random.h:420:38: error: no member named 'rotl' in namespace 'std' [clang-diagnostic-error]
        const uint64_t result = std::rotl(s0 + s1, 17) + s0;
                                ~~~~~^
/work/src/./random.h:422:21: error: no member named 'rotl' in namespace 'std' [clang-diagnostic-error]
        m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
               ~~~~~^
/work/src/./random.h:423:21: error: no member named 'rotl' in namespace 'std' [clang-diagnostic-error]
        m_s1 = std::rotl(s1, 28);
               ~~~~~^
2352 warnings and 3 errors generated.
Error while processing /work/src/bitcoin-tx.cpp.
Suppressed 2352 warnings (2352 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).
[292/598] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[293/598] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
teamcity added a comment.Dec 8 2025, 16:38
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

                 from /work/src/./chainparams.h:9,
                 from /work/src/seeder/options.cpp:7:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[548/668] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-without-wallet/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-without-wallet/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o -c /work/src/seeder/db.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/./seeder/db.h:8,
                 from /work/src/seeder/db.cpp:5:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[549/668] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[550/668] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[551/668] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[552/668] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[553/668] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/peermanager.cpp.o
[554/668] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/processor.cpp.o
[555/668] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-without-wallet/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-without-wallet/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -c /work/src/seeder/bitcoin.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/./seeder/bitcoin.h:8,
                 from /work/src/seeder/bitcoin.cpp:5:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[556/668] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[557/668] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[558/668] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[559/668] Building CXX object src/CMakeFiles/bitcoinkernel.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
teamcity added a comment.Dec 8 2025, 16:38
Build Bitcoin ABC Diffs / Diff Testing (build-fuzzer) failed.

Tail of the build log:

In file included from /work/src/wallet/salvage.cpp:6:
In file included from /work/src/./config.h:8:
In file included from /work/src/./chainparams.h:9:
In file included from /work/src/./kernel/chainparams.h:10:
In file included from /work/src/./netaddress.h:15:
/work/src/./random.h:420:38: error: no member named 'rotl' in namespace 'std'
        const uint64_t result = std::rotl(s0 + s1, 17) + s0;
                                ~~~~~^
/work/src/./random.h:422:21: error: no member named 'rotl' in namespace 'std'
        m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
               ~~~~~^
/work/src/./random.h:423:21: error: no member named 'rotl' in namespace 'std'
        m_s1 = std::rotl(s1, 28);
               ~~~~~^
3 errors generated.
[412/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-fuzzer/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-fuzzer/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fsanitize=fuzzer -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o -c /work/src/wallet/rpcwallet.cpp
In file included from /work/src/wallet/rpcwallet.cpp:6:
In file included from /work/src/./chainparams.h:9:
In file included from /work/src/./kernel/chainparams.h:10:
In file included from /work/src/./netaddress.h:15:
/work/src/./random.h:420:38: error: no member named 'rotl' in namespace 'std'
        const uint64_t result = std::rotl(s0 + s1, 17) + s0;
                                ~~~~~^
/work/src/./random.h:422:21: error: no member named 'rotl' in namespace 'std'
        m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
               ~~~~~^
/work/src/./random.h:423:21: error: no member named 'rotl' in namespace 'std'
        m_s1 = std::rotl(s1, 28);
               ~~~~~^
3 errors generated.
[413/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[414/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-fuzzer/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-fuzzer/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fsanitize=fuzzer -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o -c /work/src/wallet/scriptpubkeyman.cpp
In file included from /work/src/wallet/scriptpubkeyman.cpp:5:
In file included from /work/src/./chainparams.h:9:
In file included from /work/src/./kernel/chainparams.h:10:
In file included from /work/src/./netaddress.h:15:
/work/src/./random.h:420:38: error: no member named 'rotl' in namespace 'std'
        const uint64_t result = std::rotl(s0 + s1, 17) + s0;
                                ~~~~~^
/work/src/./random.h:422:21: error: no member named 'rotl' in namespace 'std'
        m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
               ~~~~~^
/work/src/./random.h:423:21: error: no member named 'rotl' in namespace 'std'
        m_s1 = std::rotl(s1, 28);
               ~~~~~^
3 errors generated.
[415/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[416/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[417/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[418/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[419/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[420/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[421/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[422/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-fuzzer failed with exit code 1
teamcity added a comment.Dec 8 2025, 16:39
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-diff/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-diff/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o -c /work/src/seeder/options.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/seeder/options.cpp:7:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[438/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[439/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[440/588] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-diff/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-diff/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -c /work/src/seeder/bitcoin.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/./seeder/bitcoin.h:8,
                 from /work/src/seeder/bitcoin.cpp:5:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[441/588] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
FAILED: src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-diff/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-diff/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o -MF src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o.d -o src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o -c /work/src/wallet/wallettool.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/wallet/wallettool.cpp:5:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[442/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[443/588] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[444/588] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[445/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[446/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[447/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
Harbormaster completed remote builds in B35293: Diff 56954.Dec 8 2025, 16:41
teamcity added a comment.Dec 8 2025, 16:41
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

      |                     ^~~~
[440/588] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-debug/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-debug/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o -c /work/src/seeder/options.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/seeder/options.cpp:7:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[441/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[442/588] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-debug/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-debug/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -c /work/src/seeder/bitcoin.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/./seeder/bitcoin.h:8,
                 from /work/src/seeder/bitcoin.cpp:5:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[443/588] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
FAILED: src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-debug/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-debug/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o -MF src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o.d -o src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o -c /work/src/wallet/wallettool.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/wallet/wallettool.cpp:5:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[444/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[445/588] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[446/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[447/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Dec 8 2025, 16:41
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

FAILED: src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-clang/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-clang/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o -c /work/src/seeder/options.cpp
In file included from /work/src/seeder/options.cpp:7:
In file included from /work/src/./chainparams.h:9:
In file included from /work/src/./kernel/chainparams.h:10:
In file included from /work/src/./netaddress.h:15:
/work/src/./random.h:420:38: error: no member named 'rotl' in namespace 'std'
        const uint64_t result = std::rotl(s0 + s1, 17) + s0;
                                ~~~~~^
/work/src/./random.h:422:21: error: no member named 'rotl' in namespace 'std'
        m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
               ~~~~~^
/work/src/./random.h:423:21: error: no member named 'rotl' in namespace 'std'
        m_s1 = std::rotl(s1, 28);
               ~~~~~^
3 errors generated.
[439/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[440/588] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
FAILED: src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-clang/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-clang/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o -MF src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o.d -o src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o -c /work/src/wallet/wallettool.cpp
In file included from /work/src/wallet/wallettool.cpp:5:
In file included from /work/src/./chainparams.h:9:
In file included from /work/src/./kernel/chainparams.h:10:
In file included from /work/src/./netaddress.h:15:
/work/src/./random.h:420:38: error: no member named 'rotl' in namespace 'std'
        const uint64_t result = std::rotl(s0 + s1, 17) + s0;
                                ~~~~~^
/work/src/./random.h:422:21: error: no member named 'rotl' in namespace 'std'
        m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
               ~~~~~^
/work/src/./random.h:423:21: error: no member named 'rotl' in namespace 'std'
        m_s1 = std::rotl(s1, 28);
               ~~~~~^
3 errors generated.
[441/588] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-clang/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-clang/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -c /work/src/seeder/bitcoin.cpp
In file included from /work/src/seeder/bitcoin.cpp:5:
In file included from /work/src/./seeder/bitcoin.h:8:
In file included from /work/src/./chainparams.h:9:
In file included from /work/src/./kernel/chainparams.h:10:
In file included from /work/src/./netaddress.h:15:
/work/src/./random.h:420:38: error: no member named 'rotl' in namespace 'std'
        const uint64_t result = std::rotl(s0 + s1, 17) + s0;
                                ~~~~~^
/work/src/./random.h:422:21: error: no member named 'rotl' in namespace 'std'
        m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
               ~~~~~^
/work/src/./random.h:423:21: error: no member named 'rotl' in namespace 'std'
        m_s1 = std::rotl(s1, 28);
               ~~~~~^
3 errors generated.
[442/588] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[443/588] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[444/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[445/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[446/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[447/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Dec 8 2025, 16:42
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

                 from /work/src/./chainparams.h:9,
                 from /work/src/seeder/options.cpp:7:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[435/588] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[436/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[437/588] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[438/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[439/588] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[440/588] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-diff/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-diff/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -c /work/src/seeder/bitcoin.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/./seeder/bitcoin.h:8,
                 from /work/src/seeder/bitcoin.cpp:5:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[441/588] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
FAILED: src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-diff/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-diff/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o -MF src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o.d -o src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o -c /work/src/wallet/wallettool.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/wallet/wallettool.cpp:5:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[442/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[443/588] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[444/588] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[445/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[446/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[447/588] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
teamcity added a comment.Dec 8 2025, 16:43
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/seeder/options.cpp:7:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[549/668] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-without-wallet/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-without-wallet/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o -c /work/src/seeder/db.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/./seeder/db.h:8,
                 from /work/src/seeder/db.cpp:5:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[550/668] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[551/668] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[552/668] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/peermanager.cpp.o
[553/668] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-without-wallet/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-without-wallet/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -c /work/src/seeder/bitcoin.cpp
In file included from /work/src/./netaddress.h:15,
                 from /work/src/./kernel/chainparams.h:10,
                 from /work/src/./chainparams.h:9,
                 from /work/src/./seeder/bitcoin.h:8,
                 from /work/src/seeder/bitcoin.cpp:5:
/work/src/./random.h: In member function ‘constexpr XoRoShiRo128PlusPlus::result_type XoRoShiRo128PlusPlus::operator()()’:
/work/src/./random.h:420:38: error: ‘rotl’ is not a member of ‘std’
  420 |         const uint64_t result = std::rotl(s0 + s1, 17) + s0;
      |                                      ^~~~
/work/src/./random.h:422:21: error: ‘rotl’ is not a member of ‘std’
  422 |         m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
      |                     ^~~~
/work/src/./random.h:423:21: error: ‘rotl’ is not a member of ‘std’
  423 |         m_s1 = std::rotl(s1, 28);
      |                     ^~~~
[554/668] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[555/668] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/processor.cpp.o
[556/668] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[557/668] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[558/668] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[559/668] Building CXX object src/CMakeFiles/bitcoinkernel.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
teamcity added a comment.Dec 8 2025, 16:43
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

Suppressed 2053 warnings (2053 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).
[255/598] Building CXX object src/CMakeFiles/common.dir/psbt.cpp.o
[256/598] Building CXX object src/CMakeFiles/common.dir/warnings.cpp.o
[257/598] Building CXX object src/CMakeFiles/script.dir/script/script.cpp.o
[258/598] Building CXX object src/CMakeFiles/common.dir/core_write.cpp.o
[259/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/arith_uint256.cpp.o
[260/598] Building CXX object src/CMakeFiles/script.dir/script/interpreter.cpp.o
[261/598] Building CXX object src/CMakeFiles/common.dir/rpc/request.cpp.o
[262/598] Building CXX object src/CMakeFiles/script.dir/script/sigencoding.cpp.o
[263/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/uint256.cpp.o
[264/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/hash.cpp.o
[265/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[266/598] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o
[267/598] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[268/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[269/598] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[270/598] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[271/598] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[272/598] Linking C static library src/secp256k1/libsecp256k1.a
[273/598] Linking C executable src/secp256k1/recover-bench
[274/598] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[275/598] Linking C executable src/secp256k1/verify-bench
[276/598] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[277/598] Linking C executable src/secp256k1/sign-bench
[278/598] Linking C executable src/secp256k1/internal-bench
[279/598] Linking C executable src/secp256k1/ecmult-bench
[280/598] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[281/598] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[282/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[283/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/amount.cpp.o
[284/598] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[285/598] Building CXX object src/CMakeFiles/common.dir/rpc/rawtransaction_util.cpp.o
[286/598] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[287/598] Building CXX object src/CMakeFiles/bitcoinconsensus-shared.dir/script/bitcoinconsensus.cpp.o
[288/598] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[289/598] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
FAILED: src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o 
/usr/bin/cmake -E __run_co_compile --launcher=/usr/bin/ccache --tidy="/usr/bin/clang-tidy-16;-warnings-as-errors=*;--extra-arg-before=--driver-mode=g++" --source=/work/src/bitcoin-tx.cpp -- /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I/work/src/. -I/work/abc-ci-builds/build-clang-tidy/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-clang-tidy/src/crypto/.. -I/work/src/secp256k1/include -isystem /usr/include/jemalloc -g -O2 -fPIE -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o -MF src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o.d -o src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o -c /work/src/bitcoin-tx.cpp
/work/src/./random.h:420:38: error: no member named 'rotl' in namespace 'std' [clang-diagnostic-error]
        const uint64_t result = std::rotl(s0 + s1, 17) + s0;
                                ~~~~~^
/work/src/./random.h:422:21: error: no member named 'rotl' in namespace 'std' [clang-diagnostic-error]
        m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
               ~~~~~^
/work/src/./random.h:423:21: error: no member named 'rotl' in namespace 'std' [clang-diagnostic-error]
        m_s1 = std::rotl(s1, 28);
               ~~~~~^
2352 warnings and 3 errors generated.
Error while processing /work/src/bitcoin-tx.cpp.
Suppressed 2352 warnings (2352 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).
[290/598] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[291/598] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[292/598] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[293/598] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
teamcity added a comment.Dec 8 2025, 16:43
Build Bitcoin ABC Diffs / Diff Testing (build-fuzzer) failed.

Tail of the build log:

In file included from /work/src/./kernel/chainparams.h:10:
In file included from /work/src/./netaddress.h:15:
/work/src/./random.h:420:38: error: no member named 'rotl' in namespace 'std'
        const uint64_t result = std::rotl(s0 + s1, 17) + s0;
                                ~~~~~^
/work/src/./random.h:422:21: error: no member named 'rotl' in namespace 'std'
        m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
               ~~~~~^
/work/src/./random.h:423:21: error: no member named 'rotl' in namespace 'std'
        m_s1 = std::rotl(s1, 28);
               ~~~~~^
3 errors generated.
[410/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[411/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-fuzzer/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-fuzzer/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fsanitize=fuzzer -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o -c /work/src/wallet/salvage.cpp
In file included from /work/src/wallet/salvage.cpp:6:
In file included from /work/src/./config.h:8:
In file included from /work/src/./chainparams.h:9:
In file included from /work/src/./kernel/chainparams.h:10:
In file included from /work/src/./netaddress.h:15:
/work/src/./random.h:420:38: error: no member named 'rotl' in namespace 'std'
        const uint64_t result = std::rotl(s0 + s1, 17) + s0;
                                ~~~~~^
/work/src/./random.h:422:21: error: no member named 'rotl' in namespace 'std'
        m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
               ~~~~~^
/work/src/./random.h:423:21: error: no member named 'rotl' in namespace 'std'
        m_s1 = std::rotl(s1, 28);
               ~~~~~^
3 errors generated.
[412/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/abc-ci-builds/build-fuzzer/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-fuzzer/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fsanitize=fuzzer -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++20 -MD -MT src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o -c /work/src/wallet/scriptpubkeyman.cpp
In file included from /work/src/wallet/scriptpubkeyman.cpp:5:
In file included from /work/src/./chainparams.h:9:
In file included from /work/src/./kernel/chainparams.h:10:
In file included from /work/src/./netaddress.h:15:
/work/src/./random.h:420:38: error: no member named 'rotl' in namespace 'std'
        const uint64_t result = std::rotl(s0 + s1, 17) + s0;
                                ~~~~~^
/work/src/./random.h:422:21: error: no member named 'rotl' in namespace 'std'
        m_s0 = std::rotl(s0, 49) ^ s1 ^ (s1 << 21);
               ~~~~~^
/work/src/./random.h:423:21: error: no member named 'rotl' in namespace 'std'
        m_s1 = std::rotl(s1, 28);
               ~~~~~^
3 errors generated.
[413/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[414/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[415/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[416/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[417/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[418/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[419/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[420/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[421/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[422/433] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-fuzzer failed with exit code 1
Fabien requested changes to this revision.Dec 8 2025, 20:57
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/random.h
420 ↗(On Diff #56954)

It's missing the <bit> header

This revision now requires changes to proceed.Dec 8 2025, 20:57
PiRK updated this revision to Diff 56976.Dec 9 2025, 07:55

include bit

Harbormaster completed remote builds in B35305: Diff 56976.Dec 9 2025, 08:32
Fabien accepted this revision.Dec 9 2025, 10:23
This revision is now accepted and ready to land.Dec 9 2025, 10:23
Closed by commit rABCe8a39df59817: random: move XoRoShiRo128PlusPlus into random module (authored by Pieter Wuille <pieter@wuille.net>, committed by PiRK). · Explain WhyDec 9 2025, 14:44
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe8a39df59817: random: move XoRoShiRo128PlusPlus into random module.

Revision Contents
Changeset List

PathSize
src/
56 lines
test/
3 lines
fuzz/
2 lines
16 lines
util/
test/
sanitizer_suppressions/
5 lines

Diff 56994

View Options

src/random.h

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/fuzz/crypto_chacha20.cpp

Loading...
View Options

src/test/random_tests.cpp

Loading...
View Options

src/test/util/xoroshiro128plusplus.h

Loading...
View Options

src/test/xoroshiro128plusplus_tests.cpp

Loading...
View Options

test/sanitizer_suppressions/ubsan

Loading...