Differential D19129

rpc: avoid copying into UniValue
ClosedPublic
Actions

Authored by Fabien on Dec 12 2025, 16:26.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC3e38179e660a: rpc: avoid copying into UniValue

Summary

These are simple (and hopefully obviously correct) copies that can be moves
instead.

Backport of core#30115.

Also use references for params getters when possible.

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 12 2025, 16:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 12 2025, 16:26

Fabien requested review of this revision.Dec 12 2025, 16:26

teamcity edited the summary of this revision. (Show Details)Dec 12 2025, 16:26

Harbormaster completed remote builds in B35390: Diff 57110.Dec 12 2025, 16:40

PiRK accepted this revision.Dec 15 2025, 07:56

This revision is now accepted and ready to land.Dec 15 2025, 07:56

Closed by commit rABC3e38179e660a: rpc: avoid copying into UniValue (authored by Cory Fields <cory-nospam-@coryfields.com>, committed by Fabien). · Explain WhyDec 15 2025, 09:42

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3e38179e660a: rpc: avoid copying into UniValue.

Revision Contents
Changeset List

Path

Size

src/

bitcoin-cli.cpp

4 lines

core_write.cpp

16 lines

rest.cpp

6 lines

rpc/

12 lines

2 lines

31 lines

32 lines

4 lines

28 lines

54 lines

rawtransaction_util.cpp

4 lines

server.cpp

6 lines

util.cpp

10 lines

test/

script_tests.cpp

2 lines

wallet/

rpcwallet.cpp

48 lines

test/

wallet_tests.cpp

4 lines

zmq/

zmqrpc.cpp

2 lines

Diff 57129

View Options

src/bitcoin-cli.cpp

View Options

src/core_write.cpp

View Options

src/rest.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/client.cpp

View Options

src/rpc/mempool.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/rawtransaction_util.cpp

View Options

src/rpc/server.cpp

View Options

src/rpc/util.cpp

View Options

src/test/script_tests.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/test/wallet_tests.cpp

View Options

rpc: avoid copying into UniValueClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 57129

src/bitcoin-cli.cpp

src/core_write.cpp

src/rest.cpp

src/rpc/blockchain.cpp

src/rpc/client.cpp

src/rpc/mempool.cpp

src/rpc/mining.cpp

src/rpc/misc.cpp

src/rpc/net.cpp

src/rpc/rawtransaction.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/server.cpp

src/rpc/util.cpp

src/test/script_tests.cpp

src/wallet/rpcwallet.cpp

src/wallet/test/wallet_tests.cpp

src/zmq/zmqrpc.cpp

rpc: avoid copying into UniValue
ClosedPublic
Actions

Revision Contents
Changeset List