Page MenuHomePhabricator
Differential D19145

Remove SER_GETHASH, hard-code client version in CKeyPool serialize
ClosedPublic
Actions

Authored by PiRK on Dec 17 2025, 11:35.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC688448c28910: Remove SER_GETHASH, hard-code client version in CKeyPool serialize
Summary

It was never set, so it can be removed along with any code reading it.

This concludes backport of core#28508
https://github.com/bitcoin/bitcoin/pull/28508/commits/fac29a0ab19fda457b55d7a0a37c5cd3d9680f82
Depends on D19144

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 17 2025, 11:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 17 2025, 11:35
PiRK requested review of this revision.Dec 17 2025, 11:35
teamcity edited the summary of this revision. (Show Details)Dec 17 2025, 11:35
PiRK added inline comments.Dec 17 2025, 11:40
src/wallet/scriptpubkeyman.h
129 ↗(On Diff #57168)

If this lands after the release commit I'll bump it to 320500 before landing. But I doubt that it matters. I don't understand why it isn't the highest PROTOCOL_VERSION rather than the highest CLIENT_VERSION, btw.

PiRK added inline comments.Dec 17 2025, 11:43
src/wallet/scriptpubkeyman.h
129 ↗(On Diff #57168)

I don't understand why it isn't the highest PROTOCOL_VERSION rather than the highest CLIENT_VERSION, btw.

nvm, db.h line 65, we use a CDataStream initialized with CLIENT_VERSION when we write the CKeyPool to the wallet db.

Harbormaster completed remote builds in B35431: Diff 57168.Dec 17 2025, 12:07
Fabien accepted this revision.Dec 17 2025, 13:46
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/scriptpubkeyman.h
129 ↗(On Diff #57168)

You can already rebase and bump the version

This revision is now accepted and ready to land.Dec 17 2025, 13:46
PiRK added a child revision: D19147: Remove unused GetType() from CBufferedFile and CAutoFile.Dec 17 2025, 14:21
Closed by commit rABC688448c28910: Remove SER_GETHASH, hard-code client version in CKeyPool serialize (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>, committed by PiRK). · Explain WhyDec 17 2025, 17:20
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC688448c28910: Remove SER_GETHASH, hard-code client version in CKeyPool serialize.

Revision Contents
Changeset List

PathSize
src/
1 line
wallet/
12 lines

Diff 57182

View Options

src/serialize.h

Loading...
View Options

src/wallet/scriptpubkeyman.h

Loading...