remove unused config.h includes and forward declarations
DraftPublic
Actions

Authored by PiRK on Dec 27 2025, 21:17.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

All of these source files no longer use the Config class. And it still compiles, so there is no transitive dependency on it either.

Test Plan

ninja all check-all bench-bitcoin bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr28904

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35551
Build 70555: Build Diff	build-clang · build-without-wallet · ecash-lib-integration-tests · build-clang-tidy · chronik-client-integration-tests · ecash-agora-integration-tests · lint-circular-dependencies · build-diff · build-chronik · build-fuzzer · build-chronik-plugins · build-debug · build-bench · build-bitcoinsuite-chronik-client
Build 70554: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 27 2025, 21:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 27 2025, 21:17

@bot build-chronik

teamcity awarded a token.Dec 27 2025, 21:18

PiRK edited the test plan for this revision. (Show Details)Dec 27 2025, 21:18

Harbormaster completed remote builds in B35507: Diff 57299.Dec 27 2025, 21:39

Build Bitcoin ABC Diffs / Diff Testing (ecash-agora-integration-tests) failed.

Failed tests logs:

====== AgoraPartial ALP: AgoraPartial ALP 140737488355327 for 0.000000001sat/token, dust accept.AgoraPartial ALP AgoraPartial ALP 140737488355327 for 0.000000001sat/token, dust accept ======
Error: Insufficient input sats (2740): Can only pay for 1102 fees, but 1203 required
    at TxBuilder.sign (/work/modules/ecash-lib/src/txBuilder.ts:204:23)
    at AgoraOffer.take (src/agora.ts:293:34)
    at takeAlpOffer (tests/partial-helper-alp.ts:136:48)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async Context.<anonymous> (tests/partial.alp.test.ts:446:32)
====== AgoraPartial ALP: AgoraPartial ALP 140737488355327 for 0.000001sat/token, dust accept.AgoraPartial ALP AgoraPartial ALP 140737488355327 for 0.000001sat/token, dust accept ======
Error: Insufficient input sats (2740): Can only pay for 1102 fees, but 1192 required
    at TxBuilder.sign (/work/modules/ecash-lib/src/txBuilder.ts:204:23)
    at AgoraOffer.take (src/agora.ts:293:34)
    at takeAlpOffer (tests/partial-helper-alp.ts:136:48)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async Context.<anonymous> (tests/partial.alp.test.ts:446:32)
====== AgoraPartial ALP: AgoraPartial ALP 140737488355327 for 0.001sat/token, dust accept.AgoraPartial ALP AgoraPartial ALP 140737488355327 for 0.001sat/token, dust accept ======
Error: Insufficient input sats (2740): Can only pay for 880 fees, but 1188 required
    at TxBuilder.sign (/work/modules/ecash-lib/src/txBuilder.ts:204:23)
    at AgoraOffer.take (src/agora.ts:293:34)
    at takeAlpOffer (tests/partial-helper-alp.ts:136:48)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async Context.<anonymous> (tests/partial.alp.test.ts:446:32)

Each failure log is accessible here:
AgoraPartial ALP: AgoraPartial ALP 140737488355327 for 0.000000001sat/token, dust accept.AgoraPartial ALP AgoraPartial ALP 140737488355327 for 0.000000001sat/token, dust accept
AgoraPartial ALP: AgoraPartial ALP 140737488355327 for 0.000001sat/token, dust accept.AgoraPartial ALP AgoraPartial ALP 140737488355327 for 0.000001sat/token, dust accept
AgoraPartial ALP: AgoraPartial ALP 140737488355327 for 0.001sat/token, dust accept.AgoraPartial ALP AgoraPartial ALP 140737488355327 for 0.001sat/token, dust accept