Currently the time-since value on the transactions is static. Adding an interval to update the times every 1s so the values stay more accurate.
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC2e3f3406ac6d: [e.cash] Update live transaction times in realtime
preview and check
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Seems simpler and better to just start counting up every second, without the "just now" thing.
| web/e.cash/app/components/Home/LiveCard.tsx | ||
|---|---|---|
| 32 ↗ | (On Diff #57735) | Why not just start counting up from whatever low number it starts at (0, 1, or whatever)? |
| 80 ↗ | (On Diff #57735) | Why not just update every second? |
@bot preview-e.cash
| web/e.cash/app/components/Home/LiveCard.tsx | ||
|---|---|---|
| 80 ↗ | (On Diff #57735) | eh every minute seems appropriate with the different resolutions we are showing. seems like it would be annoying to tick them every 5s, but, if it looked ok in testing i'm open to it |
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41428 for the next 60 minutes.
Tail of the build log:
#6 sha256:f12d7fac707da9b3d54b43492fa72722ce171d9a65fb66750c2deed3bc039164 #6 CACHED #14 [builder 10/20] RUN pnpm fetch --frozen-lockfile #14 sha256:827504e03b207c629a89db1652f8babb86f8f6b9c1365e99787125bad740da4c #14 CACHED #15 [builder 11/20] COPY modules/ecashaddrjs/ ./modules/ecashaddrjs/ #15 sha256:eff86a42f9a276f80ab75a073868a2bfdc92d10275f3c6f0fbbcfa24be0882f6 #15 CACHED #25 [runner 7/11] COPY --from=builder /app/web/e.cash/.next ./web/e.cash/.next #25 sha256:c10b29a04deef49550570592dfe408e3c895cd0785e5e70339616efcd0246e0a #25 CACHED #10 [runner 6/11] COPY package.json . #10 sha256:b7a62d74b4cb36a5598bd8ec94f2ba812ac5e032be9763831745c3e8229c35e3 #10 CACHED #19 [builder 15/20] RUN pnpm --filter ecashaddrjs run build #19 sha256:23d2ccd2dcebfb7b188892057d8a0b175870660446d95cd01469f06ba3b3ea48 #19 CACHED #24 [builder 20/20] RUN pnpm --filter e.cash run build #24 sha256:8d89e0e2deaf272bd158372c454ce8ed4ee0fb6000af753c4b03238c9fe34c13 #24 CACHED #11 [builder 7/20] COPY modules/ecashaddrjs/package.json ./modules/ecashaddrjs/ #11 sha256:e08f9e4b6b5820332bdea7615b16ee0dd9be9a9d6a9b835ffebce47763bda4fb #11 CACHED #23 [builder 19/20] COPY web/e.cash/next.preview.ts web/e.cash/next.config.ts #23 sha256:7f74f34b353cc2f1e3141f59db49845f3525d190b79475af20807a04c0b46857 #23 CACHED #16 [builder 12/20] COPY modules/chronik-client/ ./modules/chronik-client/ #16 sha256:08422b33b0b21b14d783c0132ab53aa8d839ade42a6874d945dfdc83d2fc3625 #16 CACHED #5 [runner 2/11] WORKDIR /app #5 sha256:951a962c7e8b9f9ab6dc1669c561ca22f0a207bc47c22288a9c5c22e83f50af2 #5 CACHED #9 [runner 5/11] COPY pnpm-lock.yaml . #9 sha256:bb0b18f4d7015d8ba76c72cd77a7132678554a9aa10f37320fef8f76aa361c5c #9 CACHED #29 [runner 11/11] WORKDIR /app/web/e.cash #29 sha256:7b88e517b1449643bdbebb8e99afd6c03c4b7db0f5501b22596ed8189f0932c0 #29 CACHED #30 exporting to image #30 sha256:e8c613e07b0b7ff33893b694f7759a10d42e180f2b4dc349fb57dc6b71dcab00 #30 exporting layers done #30 writing image sha256:bffaf0d91736de31cf5f8d0444ed7a10fe2bed3a4eafb1dbf9ed505ed71125a1 done #30 naming to docker.io/library/preview-e.cash-0675f18e9d done #30 DONE 0.0s docker: Error response from daemon: Conflict. The container name "/preview-e.cash-0675f18e9d" is already in use by container "fca66f8c17ea0ac6131aabee73d0c4df93ae7a16d22c94eb19a4a440af25a06b". You have to remove (or rename) that container to be able to reuse that name. See 'docker run --help'. Build preview-e.cash failed with exit code 125
The times match up on the explorer for me...not sure what would be going on there, but possibly different calculation/rounding method.
Are they way off? really it shouldnt be minutes off
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41790 for the next 60 minutes.
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41374 for the next 60 minutes.