Differential D19400

[secp256k1] build: Prebuild and distribute ecmult_gen table
ClosedPublic
Actions

Authored by PiRK on Jan 19 2026, 10:19.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa2f37031a3c5: [secp256k1] build: Prebuild and distribute ecmult_gen table

Summary

Improve Makefile.am for both prebuilt tables files
On the way, tidy EXTRA_DIST: Move the header files to noinst_HEADERS, where they conceptually belong, and add missing SECURITY.md to EXTRA_DIST

This is a partial backport of secp256k1#988 and core#1047
https://github.com/bitcoin-core/secp256k1/pull/988/commits/ad63bb4c296e6007dab22cda05fd599b20139362
https://github.com/bitcoin-core/secp256k1/pull/988/commits/d94a37a20c3b5b44f1bcf60d309ffc50727e18e4
https://github.com/bitcoin-core/secp256k1/pull/1047/commits/26a022a3a0e3fceb1cd2e882e1476c950cabc2e8
Depends on D19399

Test Plan

Delete either one of ecmult_gen_static_prec_table.h and ecmult_static_pre_g.h, or both, or none of them, and make sure the cmake build works (and only the deleted header is regenerated in the build dir):

(( RANDOM % 2 == 0 )) && rm -f ../src/secp256k1/src/ecmult_gen_static_prec_table.h && echo "Deleted!" || echo "Survived"
(( RANDOM % 2 == 0 )) && rm -f ../src/secp256k1/src/ecmult_static_pre_g.h && echo "Deleted!" || echo "Survived"
cmake .. -GNinja
ninja secp256k1 check-secp256k1
git stash   # restore deleted headers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 19 2026, 10:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2026, 10:19

teamcity edited the summary of this revision. (Show Details)Jan 19 2026, 10:19

PiRK added a child revision: D19401: [secp256k1] ci: Test `make precomp`.Jan 19 2026, 10:21

PiRK retitled this revision from build: Prebuild and distribute ecmult_gen table to [secp256k1] build: Prebuild and distribute ecmult_gen table.Jan 19 2026, 10:24

Harbormaster completed remote builds in B35859: Diff 57839.Jan 19 2026, 11:18

PiRK mentioned this in D19382: [secp256k1] ecmult_gen: Move table creation to new file and force static prec.Jan 19 2026, 12:55

PiRK mentioned this in D19383: [secp256k1] refactor: Decouple table generation and ecmult_gen context.Jan 19 2026, 12:59

PiRK mentioned this in D19384: [secp256k1] ecmult_gen: Simplify ecmult_gen context after making table static.

PiRK mentioned this in D19385: [secp256k1] ecmult_gen: Make code consistent with comment.

PiRK mentioned this in D19386: [secp256k1] refactor: Rename file that contains static ecmult_gen table.Jan 19 2026, 13:03

PiRK mentioned this in D19387: [secp256k1] refactor: Make generator a parameter of ecmult_gen_create_prec_table.

PiRK mentioned this in D19388: [secp256k1] exhaustive_tests: Fix with ecmult_gen table with custom generator.

PiRK mentioned this in D19394: [secp256k1] doc: Remove obsolete hint for valgrind stack size.Jan 19 2026, 13:06

PiRK published this revision for review.Jan 19 2026, 13:35

PiRK mentioned this in D19395: [secp256k1] refactor: Move default callbacks to util.h.

PiRK mentioned this in D19396: [secp256k1] refactor: Make PREC_BITS a parameter of ecmult_gen_build_prec_table.