Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCab935c9d3025: [secp256k1] build: Remove #undef hack for ASM in the precomputation programs

Summary

This was necessary because we used to cross-compile the library but
compile the precomputation programs for the build host. Now it's no
longer necessary and we can cleanly link even the external ASM
(which was the intent of #935).

On the way, remove an obsolete "-I" parameter.

This is a partial backport of secp256k1#988
https://github.com/bitcoin-core/secp256k1/pull/988/commits/7dfceceea692c4118829c06128c41623b2373ac2

Depends on D19401

Test Plan

delete the pregenerated headers, then
ninja sepc256k1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 19 2026, 10:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2026, 10:24

teamcity edited the summary of this revision. (Show Details)Jan 19 2026, 10:24

PiRK retitled this revision from build: Remove #undef hack for ASM in the precomputation programs to [secp256k1] build: Remove #undef hack for ASM in the precomputation programs.Jan 19 2026, 10:24

Harbormaster completed remote builds in B35861: Diff 57841.Jan 19 2026, 11:44

PiRK published this revision for review.Jan 19 2026, 13:36

Fabien accepted this revision.Jan 19 2026, 14:02

This revision is now accepted and ready to land.Jan 19 2026, 14:02

@bot build-coverage

teamcity awarded a token.Jan 20 2026, 10:52

@bot build-linux-aarch64

teamcity updated a token.Jan 20 2026, 11:35

Closed by commit rABCab935c9d3025: [secp256k1] build: Remove #undef hack for ASM in the precomputation programs (authored by Tim Ruffing <crypto@timruffing.de>, committed by PiRK). · Explain WhyJan 21 2026, 07:19

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCab935c9d3025: [secp256k1] build: Remove #undef hack for ASM in the precomputation programs.

PiRK mentioned this in D19420: [secp256k1] use relative imports in modules/schnorr.Jan 21 2026, 10:01