Differential D19517

[secp256k1] ci, gha: Add Windows jobs based on Linux image
ClosedPublic
Actions

Authored by PiRK on Feb 2 2026, 16:14.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCb65677512835: [secp256k1] ci, gha: Add Windows jobs based on Linux image

Summary

And mostly prevent "-v/--version: not found" irrelevant errors ($CC, $WRAPPER_CMD and valgrind are not necessarily defined)

This is a backport of secp256k1#1398 and secp256k1#1146

with some necesserary dockerfile changes from secp256k1#1084 to unbreak the i686-win32 job (now restored after i removed it in D19449)

Test Plan

push to my clone of secp256k1 on github, wait for github actions to finish

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 2 2026, 16:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 2 2026, 16:14

PiRK requested review of this revision.Feb 2 2026, 16:14

teamcity edited the summary of this revision. (Show Details)Feb 2 2026, 16:14

https://github.com/PiRK/secp256k1/actions/runs/21597198240

PiRK added inline comments.Feb 2 2026, 16:19

src/secp256k1/.github/workflows/ci.yml
71 ↗	(On Diff #58173)	EXPERIMENTAL is still needed, we didn't backport the PR that removes that ELLSWIFT does not exist yet in our fork, we will add it when relevant
99 ↗	(On Diff #58173)	All the tasks printing logs are not needed because, at least for now, we print them directly in ./ci/build_*.sh

PiRK added inline comments.Feb 2 2026, 16:23

src/secp256k1/ci/linux-debian.Dockerfile
3–20 ↗	(On Diff #58173)	partial backport of https://github.com/bitcoin-core/secp256k1/pull/1084/changes#diff-751ef1d9fd31c5787e12221f590262dcf7d96cfb166d456e06bd0ccab115b60d The rest of the dockerfile changes from that PR are not yet relevant, as we haven't yet backported the CI jobs that compile for Windows on Linux with MSVC+Wine. But we need wine64, wine32, the crosscompiler for i686-win32.

PiRK added inline comments.Feb 2 2026, 16:26

src/secp256k1/ci/build_autotools.sh
27 ↗	(On Diff #58173)	this tells us the version of wine, useful in case we run into any more flakyness with those new jobs. The other two changes above are unrelated, but I grabbed them as part of the same PR

Harbormaster completed remote builds in B36061: Diff 58173.Feb 2 2026, 16:34

push to my clone of secp256k1 on twitter

Really ?

src/secp256k1/.github/workflows/ci.yml
72 ↗	(On Diff #58173)	No SCHNORR ?

This revision now requires changes to proceed.Feb 2 2026, 17:09

In D19517#444042, @Fabien wrote:

push to my clone of secp256k1 on twitter

Really ?

oops, wrong social media.... Fixed.

PiRK requested review of this revision.Feb 2 2026, 20:19

PiRK added inline comments.

src/secp256k1/.github/workflows/ci.yml
72 ↗	(On Diff #58173)	SCHNORR is "yes" by default (line 32)

Fabien accepted this revision.Feb 2 2026, 21:29

Fabien added inline comments.

src/secp256k1/.github/workflows/ci.yml
72 ↗	(On Diff #58173)	what about multiset then ?

This revision is now accepted and ready to land.Feb 2 2026, 21:29

test MULTISET, remove the corresponding Cirrus job

Harbormaster completed remote builds in B36066: Diff 58178.Feb 3 2026, 10:31

Closed by commit rABCb65677512835: [secp256k1] ci, gha: Add Windows jobs based on Linux image (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyFeb 3 2026, 13:35

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCb65677512835: [secp256k1] ci, gha: Add Windows jobs based on Linux image.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

17 lines

.github/

actions/

run-in-docker-action/

37 lines

workflows/

63 lines

ci/

build_autotools.sh

13 lines

linux-debian.Dockerfile

14 lines

Diff 58179

src/secp256k1/.cirrus.yml

Loading...

src/secp256k1/.github/actions/run-in-docker-action/action.yml

Loading...

src/secp256k1/.github/workflows/ci.yml

Loading...

src/secp256k1/ci/build_autotools.sh

Loading...

src/secp256k1/ci/linux-debian.Dockerfile

Loading...