Differential D19535

[avalanche] Remove deprecated availability_score field from getavalanchepeerinfo
ClosedPublic
Actions

Authored by Fabien on Mon, Feb 9, 08:53.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC738f81c0cb60: [avalanche] Remove deprecated availability_score field from getavalanchepeerinfo

Summary

This was deprecated and not computed since v0.30.12.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mon, Feb 9, 08:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Feb 9, 08:53

Fabien requested review of this revision.Mon, Feb 9, 08:53

Harbormaster completed remote builds in B36090: Diff 58217.Mon, Feb 9, 08:57

Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[401/587] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[402/587] Linking CXX shared library src/libbitcoinconsensus.so.0.32.7
[403/587] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[404/587] Linking C executable src/secp256k1/ecmult-bench
[405/587] Linking CXX executable src/bitcoin-cli
[406/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[407/587] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[408/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[409/587] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[410/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[411/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[412/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[413/587] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[414/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[415/587] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[416/587] Linking CXX executable src/bitcoin-tx
[417/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[418/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[419/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[420/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[421/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[422/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[423/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[424/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[425/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[426/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[427/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[428/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[429/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[430/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[431/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[432/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[433/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[434/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[435/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[436/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[437/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[438/587] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[439/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[440/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[441/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[442/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[443/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[444/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[445/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[446/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[447/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[448/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[449/587] Linking CXX executable src/iguana/iguana
[450/587] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[451/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[452/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[453/587] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[454/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[455/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[456/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[457/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[458/587] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Fabien added a child revision: D19537: [avalanche] Remove deprecated availability_score field from getpeerinfo.Mon, Feb 9, 08:58

Fix clang warning

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[412/597] Linking C executable src/secp256k1/internal-bench
[413/597] Linking C executable src/secp256k1/ecmult-bench
[414/597] Linking C executable src/secp256k1/bench
[415/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[416/597] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[417/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[418/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[419/597] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[420/597] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[421/597] Linking CXX executable src/bitcoin-tx
[422/597] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[423/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[424/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[425/597] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[426/597] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[427/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[428/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[429/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[430/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[431/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[432/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[433/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[434/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[435/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[436/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[437/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[438/597] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[439/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[440/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[441/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[442/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[443/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[444/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[445/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[446/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[447/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[448/597] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[449/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[450/597] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[451/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[452/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[453/597] Linking CXX static library chronik/libchronik-bridge.a
[454/597] Linking CXX static library chronik/libchronik.a
[455/597] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[456/597] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[457/597] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[458/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[459/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[460/597] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[461/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[462/597] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[463/597] Linking CXX executable src/iguana/iguana
[464/597] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[465/597] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[466/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[467/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[468/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[469/597] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Harbormaster completed remote builds in B36093: Diff 58220.Mon, Feb 9, 09:40

PiRK accepted this revision.Mon, Feb 9, 10:37

This revision is now accepted and ready to land.Mon, Feb 9, 10:37

Closed by commit rABC738f81c0cb60: [avalanche] Remove deprecated availability_score field from getavalanchepeerinfo (authored by Fabien). · Explain WhyMon, Feb 9, 11:50

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC738f81c0cb60: [avalanche] Remove deprecated availability_score field from getavalanchepeerinfo.