Page MenuHomePhabricator
Differential D19537

[avalanche] Remove deprecated availability_score field from getpeerinfo
ClosedPublic
Actions

Authored by Fabien on Mon, Feb 9, 08:58.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCda34ebc8031a: [avalanche] Remove deprecated availability_score field from getpeerinfo
Summary

This was deprecated and not computed since v0.30.12, similar to D19535.

Depends on D19535 and D19536.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Mon, Feb 9, 08:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Feb 9, 08:58
Fabien requested review of this revision.Mon, Feb 9, 08:58
Fabien updated this revision to Diff 58221.Mon, Feb 9, 09:01

Rebase (clang fix)

Harbormaster completed remote builds in B36092: Diff 58219.Mon, Feb 9, 09:18
teamcity added a comment.Mon, Feb 9, 09:18
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[408/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[409/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[410/587] Building CXX object src/CMakeFiles/server.dir/index/blockfilterindex.cpp.o
[411/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[412/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[413/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[414/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[415/587] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[416/587] Linking CXX executable src/bitcoin-cli
[417/587] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
FAILED: src/CMakeFiles/server.dir/rpc/net.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I/work/src/leveldb/helpers/memenv -I/work/src/. -I/work/abc-ci-builds/build-debug/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-debug/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -I/work/src/crc32c/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wno-implicit-fallthrough -Wno-psabi -Wno-unused-parameter -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Wsuggest-override -Woverloaded-virtual -std=gnu++20 -MD -MT src/CMakeFiles/server.dir/rpc/net.cpp.o -MF src/CMakeFiles/server.dir/rpc/net.cpp.o.d -o src/CMakeFiles/server.dir/rpc/net.cpp.o -c /work/src/rpc/net.cpp
/work/src/rpc/net.cpp: In lambda function:
/work/src/rpc/net.cpp:220:32: error: unused variable ‘argsman’ [-Werror=unused-variable]
  220 |             const ArgsManager &argsman = EnsureArgsman(node);
      |                                ^~~~~~~
cc1plus: all warnings being treated as errors
[418/587] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[419/587] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[420/587] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[421/587] Building CXX object src/CMakeFiles/server.dir/net.cpp.o
[422/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[423/587] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[424/587] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[425/587] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[426/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[427/587] Linking CXX executable src/bitcoin-tx
[428/587] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[429/587] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[430/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[431/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[432/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[433/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[434/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[435/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[436/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[437/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[438/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[439/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[440/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[441/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[442/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[443/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[444/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[445/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[446/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[447/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[448/587] Linking CXX executable src/iguana/iguana
[449/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[450/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[451/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[452/587] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[453/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[454/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[455/587] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[456/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[457/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[458/587] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Mon, Feb 9, 09:18
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[401/587] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[402/587] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[403/587] Linking C executable src/secp256k1/ecmult-bench
[404/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[405/587] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[406/587] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[407/587] Linking CXX executable src/bitcoin-cli
[408/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[409/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[410/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[411/587] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[412/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[413/587] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[414/587] Linking CXX executable src/bitcoin-tx
[415/587] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[416/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[417/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[418/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[419/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[420/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[421/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[422/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[423/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[424/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[425/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[426/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[427/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[428/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[429/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[430/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[431/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[432/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[433/587] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[434/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[435/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[436/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[437/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[438/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[439/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[440/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[441/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[442/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[443/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[444/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[445/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[446/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[447/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[448/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[449/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[450/587] Linking CXX executable src/iguana/iguana
[451/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[452/587] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[453/587] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[454/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[455/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[456/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[457/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[458/587] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Mon, Feb 9, 09:20
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[521/667] Building CXX object src/CMakeFiles/bitcoinkernel.dir/util/asmap.cpp.o
[522/667] Linking C static library src/secp256k1/libsecp256k1.a
[523/667] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[524/667] Linking C executable src/secp256k1/internal-bench
[525/667] Linking CXX static library src/libbitcoinconsensus.a
[526/667] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[527/667] Linking C executable src/secp256k1/ecmult-bench
[528/667] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[529/667] Linking CXX static library src/libscript.a
[530/667] Building C object src/secp256k1/CMakeFiles/bench.dir/src/bench.c.o
[531/667] Building CXX object src/CMakeFiles/bitcoinkernel.dir/net.cpp.o
[532/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[533/667] Linking C executable src/secp256k1/bench
[534/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[535/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[536/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[537/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[538/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[539/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[540/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[541/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[542/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[543/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[544/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[545/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[546/667] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[547/667] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[548/667] Linking CXX static library src/libcommon.a
[549/667] Linking CXX shared library src/libbitcoinconsensus.so.0.32.8
[550/667] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[551/667] Linking CXX executable src/bitcoin-cli
[552/667] Building CXX object src/CMakeFiles/bitcoinkernel.dir/init/common.cpp.o
[553/667] Linking CXX executable src/bitcoin-tx
[554/667] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[555/667] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[556/667] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[557/667] Building CXX object src/CMakeFiles/bitcoinkernel.dir/txdb.cpp.o
[558/667] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
FAILED: src/CMakeFiles/server.dir/rpc/net.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I/work/src/leveldb/helpers/memenv -I/work/src/. -I/work/abc-ci-builds/build-without-wallet/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-without-wallet/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -I/work/src/crc32c/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wno-implicit-fallthrough -Wno-psabi -Wno-unused-parameter -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Wsuggest-override -Woverloaded-virtual -std=gnu++20 -MD -MT src/CMakeFiles/server.dir/rpc/net.cpp.o -MF src/CMakeFiles/server.dir/rpc/net.cpp.o.d -o src/CMakeFiles/server.dir/rpc/net.cpp.o -c /work/src/rpc/net.cpp
/work/src/rpc/net.cpp: In lambda function:
/work/src/rpc/net.cpp:220:32: error: unused variable ‘argsman’ [-Werror=unused-variable]
  220 |             const ArgsManager &argsman = EnsureArgsman(node);
      |                                ^~~~~~~
cc1plus: all warnings being treated as errors
[559/667] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[560/667] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[561/667] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[562/667] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[563/667] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[564/667] Linking CXX executable src/iguana/iguana
[565/667] Building CXX object src/CMakeFiles/bitcoinkernel.dir/txmempool.cpp.o
[566/667] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[567/667] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[568/667] Linking CXX static library src/libbitcoinkernel.a
[569/667] Linking CXX executable src/bitcoin-chainstate
[570/667] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[571/667] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
teamcity added a comment.Mon, Feb 9, 09:21
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[401/587] Linking C executable src/secp256k1/ecmult-bench
[402/587] Linking CXX static library src/libscript.a
[403/587] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[404/587] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[405/587] Linking CXX static library src/libcommon.a
[406/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[407/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[408/587] Linking CXX shared library src/libbitcoinconsensus.so.0.32.8
[409/587] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[410/587] Linking CXX executable src/bitcoin-cli
[411/587] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[412/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[413/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[414/587] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[415/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[416/587] Linking CXX executable src/bitcoin-tx
[417/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[418/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[419/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[420/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[421/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[422/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[423/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[424/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[425/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[426/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[427/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[428/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[429/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[430/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[431/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[432/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[433/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[434/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[435/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[436/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[437/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[438/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[439/587] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[440/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[441/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[442/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[443/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[444/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[445/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[446/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[447/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[448/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[449/587] Linking CXX executable src/iguana/iguana
[450/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[451/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[452/587] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[453/587] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[454/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[455/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[456/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[457/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[458/587] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
teamcity added a comment.Mon, Feb 9, 09:23
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[412/597] Linking C executable src/secp256k1/bench
[413/597] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[414/597] Linking CXX executable src/bitcoin-cli
[415/597] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[416/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[417/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[418/597] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[419/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[420/597] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[421/597] Linking CXX executable src/bitcoin-tx
[422/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[423/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[424/597] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[425/597] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[426/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[427/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[428/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[429/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[430/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[431/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[432/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[433/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[434/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[435/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[436/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[437/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[438/597] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[439/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[440/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[441/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[442/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[443/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[444/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[445/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[446/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[447/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[448/597] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[449/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[450/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[451/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[452/597] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[453/597] Linking CXX static library chronik/libchronik-bridge.a
[454/597] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[455/597] Linking CXX static library chronik/libchronik.a
[456/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[457/597] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[458/597] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[459/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[460/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[461/597] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[462/597] Linking CXX executable src/iguana/iguana
[463/597] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[464/597] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[465/597] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[466/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[467/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[468/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[469/597] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
Harbormaster completed remote builds in B36094: Diff 58221.Mon, Feb 9, 09:26
teamcity added a comment.Mon, Feb 9, 09:26
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[401/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[402/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[403/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[404/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[405/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[406/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[407/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[408/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[409/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[410/587] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[411/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[412/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[413/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[414/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[415/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[416/587] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[417/587] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[418/587] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[419/587] Linking CXX executable src/bitcoin-cli
[420/587] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[421/587] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[422/587] Building CXX object src/CMakeFiles/server.dir/net.cpp.o
[423/587] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[424/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[425/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[426/587] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[427/587] Linking CXX executable src/bitcoin-tx
[428/587] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[429/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[430/587] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[431/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[432/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[433/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[434/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[435/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[436/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[437/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[438/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[439/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[440/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[441/587] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[442/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[443/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[444/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[445/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[446/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[447/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[448/587] Linking CXX executable src/iguana/iguana
[449/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[450/587] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[451/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[452/587] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[453/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[454/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[455/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[456/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[457/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[458/587] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Mon, Feb 9, 09:27
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[415/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[416/587] Linking C static library src/secp256k1/libsecp256k1.a
[417/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[418/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[419/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[420/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[421/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[422/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[423/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[424/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[425/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[426/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[427/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[428/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[429/587] Installing component secp256k1
-- Install configuration: "Debug"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[430/587] Linking C executable src/secp256k1/bench
[431/587] Linking C executable src/secp256k1/ecmult-bench
[432/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[433/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[434/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[435/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[436/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[437/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[438/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[439/587] Linking C executable src/secp256k1/internal-bench
[440/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[441/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[442/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[443/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[444/587] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[445/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[446/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[447/587] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[448/587] Linking CXX static library src/libbitcoinconsensus.a
[449/587] Linking CXX static library src/libscript.a
[450/587] Linking CXX static library src/libcommon.a
[451/587] Linking CXX shared library src/libbitcoinconsensus.so.0.32.8
[452/587] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[453/587] Linking CXX executable src/bitcoin-cli
[454/587] Linking CXX executable src/iguana/iguana
[455/587] Linking CXX executable src/bitcoin-tx
[456/587] Linking CXX static library src/wallet/libwallet.a
[457/587] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
FAILED: src/CMakeFiles/server.dir/rpc/net.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I/work/src/leveldb/helpers/memenv -I/work/src/. -I/work/abc-ci-builds/build-debug/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-debug/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -I/work/src/crc32c/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wno-implicit-fallthrough -Wno-psabi -Wno-unused-parameter -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Wsuggest-override -Woverloaded-virtual -std=gnu++20 -MD -MT src/CMakeFiles/server.dir/rpc/net.cpp.o -MF src/CMakeFiles/server.dir/rpc/net.cpp.o.d -o src/CMakeFiles/server.dir/rpc/net.cpp.o -c /work/src/rpc/net.cpp
/work/src/rpc/net.cpp: In lambda function:
/work/src/rpc/net.cpp:220:32: error: unused variable ‘argsman’ [-Werror=unused-variable]
  220 |             const ArgsManager &argsman = EnsureArgsman(node);
      |                                ^~~~~~~
cc1plus: all warnings being treated as errors
[458/587] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Mon, Feb 9, 09:28
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[408/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[409/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[410/587] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[411/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[412/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[413/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[414/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[415/587] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[416/587] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[417/587] Linking CXX executable src/bitcoin-cli
[418/587] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
FAILED: src/CMakeFiles/server.dir/rpc/net.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I/work/src/leveldb/helpers/memenv -I/work/src/. -I/work/abc-ci-builds/build-diff/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-diff/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -I/work/src/crc32c/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wno-implicit-fallthrough -Wno-psabi -Wno-unused-parameter -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Wsuggest-override -Woverloaded-virtual -std=gnu++20 -MD -MT src/CMakeFiles/server.dir/rpc/net.cpp.o -MF src/CMakeFiles/server.dir/rpc/net.cpp.o.d -o src/CMakeFiles/server.dir/rpc/net.cpp.o -c /work/src/rpc/net.cpp
/work/src/rpc/net.cpp: In lambda function:
/work/src/rpc/net.cpp:220:32: error: unused variable ‘argsman’ [-Werror=unused-variable]
  220 |             const ArgsManager &argsman = EnsureArgsman(node);
      |                                ^~~~~~~
cc1plus: all warnings being treated as errors
[419/587] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[420/587] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[421/587] Building CXX object src/CMakeFiles/server.dir/net.cpp.o
[422/587] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[423/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[424/587] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[425/587] Linking CXX executable src/bitcoin-tx
[426/587] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[427/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[428/587] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[429/587] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[430/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[431/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[432/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[433/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[434/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[435/587] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[436/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[437/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[438/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[439/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[440/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[441/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[442/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[443/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[444/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[445/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[446/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[447/587] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[448/587] Linking CXX executable src/iguana/iguana
[449/587] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[450/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[451/587] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[452/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[453/587] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[454/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[455/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[456/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[457/587] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[458/587] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
teamcity added a comment.Mon, Feb 9, 09:29
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[521/667] Building CXX object src/CMakeFiles/bitcoinkernel.dir/policy/block/preconsensus.cpp.o
[522/667] Building CXX object src/CMakeFiles/bitcoinkernel.dir/policy/block/stakingrewards.cpp.o
[523/667] Building CXX object src/CMakeFiles/bitcoinkernel.dir/protocol.cpp.o
[524/667] Building CXX object src/CMakeFiles/bitcoinkernel.dir/timedata.cpp.o
[525/667] Building CXX object src/CMakeFiles/bitcoinkernel.dir/util/asmap.cpp.o
[526/667] Building CXX object src/CMakeFiles/bitcoinkernel.dir/util/sock.cpp.o
[527/667] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/precomputed_ecmult_gen.c.o
[528/667] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[529/667] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[530/667] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/precomputed_ecmult.c.o
[531/667] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[532/667] Building C object src/secp256k1/CMakeFiles/bench.dir/src/bench.c.o
[533/667] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[534/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[535/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[536/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[537/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[538/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[539/667] Building CXX object src/CMakeFiles/bitcoin-chainstate.dir/bitcoin-chainstate.cpp.o
[540/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[541/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[542/667] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[543/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[544/667] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[545/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[546/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[547/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[548/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[549/667] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[550/667] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[551/667] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[552/667] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[553/667] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[554/667] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[555/667] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[556/667] Linking C static library src/secp256k1/libsecp256k1.a
[557/667] Linking C executable src/secp256k1/internal-bench
[558/667] Linking C executable src/secp256k1/bench
[559/667] Linking C executable src/secp256k1/ecmult-bench
[560/667] Linking CXX static library src/libbitcoinconsensus.a
[561/667] Linking CXX static library src/libscript.a
[562/667] Linking CXX static library src/libcommon.a
[563/667] Linking CXX shared library src/libbitcoinconsensus.so.0.32.8
[564/667] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[565/667] Linking CXX executable src/iguana/iguana
[566/667] Linking CXX executable src/bitcoin-cli
[567/667] Linking CXX executable src/bitcoin-tx
[568/667] Linking CXX static library src/libbitcoinkernel.a
[569/667] Linking CXX executable src/bitcoin-chainstate
[570/667] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
FAILED: src/CMakeFiles/server.dir/rpc/net.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I/work/src/leveldb/helpers/memenv -I/work/src/. -I/work/abc-ci-builds/build-without-wallet/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-without-wallet/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -I/work/src/crc32c/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wno-implicit-fallthrough -Wno-psabi -Wno-unused-parameter -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Wsuggest-override -Woverloaded-virtual -std=gnu++20 -MD -MT src/CMakeFiles/server.dir/rpc/net.cpp.o -MF src/CMakeFiles/server.dir/rpc/net.cpp.o.d -o src/CMakeFiles/server.dir/rpc/net.cpp.o -c /work/src/rpc/net.cpp
/work/src/rpc/net.cpp: In lambda function:
/work/src/rpc/net.cpp:220:32: error: unused variable ‘argsman’ [-Werror=unused-variable]
  220 |             const ArgsManager &argsman = EnsureArgsman(node);
      |                                ^~~~~~~
cc1plus: all warnings being treated as errors
[571/667] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
teamcity added a comment.Mon, Feb 9, 09:30
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[412/597] Linking CXX executable src/bitcoin-cli
[413/597] Linking C executable src/secp256k1/bench
[414/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[415/597] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[416/597] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[417/597] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[418/597] Linking CXX executable src/bitcoin-tx
[419/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[420/597] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[421/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[422/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[423/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[424/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[425/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[426/597] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[427/597] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[428/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[429/597] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[430/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[431/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[432/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[433/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[434/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[435/597] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[436/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[437/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[438/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[439/597] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[440/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[441/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[442/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[443/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[444/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[445/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[446/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[447/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[448/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[449/597] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[450/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[451/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[452/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[453/597] Linking CXX static library chronik/libchronik-bridge.a
[454/597] Linking CXX static library chronik/libchronik.a
[455/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[456/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[457/597] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[458/597] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[459/597] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[460/597] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[461/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[462/597] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[463/597] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[464/597] Linking CXX executable src/iguana/iguana
[465/597] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[466/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[467/597] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[468/597] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[469/597] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
Fabien updated this revision to Diff 58223.Mon, Feb 9, 09:35

Another clang fix

Harbormaster completed remote builds in B36096: Diff 58223.Mon, Feb 9, 09:54
PiRK accepted this revision.Mon, Feb 9, 10:38
This revision is now accepted and ready to land.Mon, Feb 9, 10:38
Closed by commit rABCda34ebc8031a: [avalanche] Remove deprecated availability_score field from getpeerinfo (authored by Fabien). · Explain WhyMon, Feb 9, 11:50
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCda34ebc8031a: [avalanche] Remove deprecated availability_score field from getpeerinfo.
Flukjokrax awarded a token.Mon, Feb 9, 19:12

Revision Contents
Changeset List

PathSize
doc/
5 lines
src/
rpc/
12 lines
test/
functional/
28 lines

Diff 58230

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

test/functional/rpc_deprecated.py

Loading...