Page MenuHomePhabricator
Differential D19551

[buildbot] remove dependency on third-party mock library
ClosedPublic
Actions

Authored by PiRK on Wed, Feb 11, 15:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7f0bd273417e: [buildbot] remove dependency on third-party mock library
Summary

See https://pypi.org/project/mock/#description:

mock is now part of the Python standard library, available as unittest.mock in Python 3.3 onwards.

Depends on D19550

Test Plan

pytest

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Feb 11, 15:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Feb 11, 15:16
PiRK requested review of this revision.Wed, Feb 11, 15:16
PiRK edited the summary of this revision. (Show Details)Wed, Feb 11, 15:16
PiRK added a parent revision: D19550: [buildbot] replace Cirrus status with GitHub Actions status in phabricator.
PiRK added inline comments.
contrib/buildbot/test/test_endpoint_buildDiff.py
10–12 ↗(On Diff #58265)

we were already using a weird mix of both

Harbormaster completed remote builds in B36121: Diff 58265.Wed, Feb 11, 15:23
teamcity added a comment.Wed, Feb 11, 15:23
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Fabien accepted this revision.Wed, Feb 11, 16:53
This revision is now accepted and ready to land.Wed, Feb 11, 16:53
PiRK updated this revision to Diff 58270.Wed, Feb 11, 20:06

rebase

Harbormaster completed remote builds in B36125: Diff 58270.Wed, Feb 11, 20:19
Closed by commit rABC7f0bd273417e: [buildbot] remove dependency on third-party mock library (authored by PiRK). · Explain WhyThu, Feb 12, 06:51
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC7f0bd273417e: [buildbot] remove dependency on third-party mock library.

Revision Contents
Changeset List

Diff 58281

View Options

contrib/buildbot/requirements.txt

Loading...
View Options

contrib/buildbot/test/mocks/githubactions.py

Loading...
View Options

contrib/buildbot/test/mocks/phabricator.py

Loading...
View Options

contrib/buildbot/test/mocks/slackbot.py

Loading...
View Options

contrib/buildbot/test/mocks/teamcity.py

Loading...
View Options

contrib/buildbot/test/test_endpoint_backportcheck.py

Loading...
View Options

contrib/buildbot/test/test_endpoint_buildDiff.py

Loading...
View Options

contrib/buildbot/test/test_endpoint_status.py

Loading...
View Options

contrib/buildbot/test/test_endpoint_triggerCI.py

Loading...
View Options

contrib/buildbot/test/test_persist_database.py

Loading...
View Options

contrib/buildbot/test/test_phabricator.py

Loading...
View Options

contrib/buildbot/test/test_slackbot.py

Loading...
View Options

contrib/buildbot/test/test_teamcity.py

Loading...