Page MenuHomePhabricator
Differential D19573

[secp256k1] Remove usage of CHECK from non-test file
ClosedPublic
Actions

Authored by PiRK on Fri, Feb 13, 15:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe58090722e37: [secp256k1] Remove usage of CHECK from non-test file
Summary

Currently CHECK is used only in test and bench mark files except for one
usage in ecmult_impl.h.

We would like to move the definition of CHECK out of util.h so that
util.h no longer has a hard dependency on stdio.h.

Done in preparation for moving the definition of CHECK as part of an
effort to allow secp256k1 to be compiled to WASM as part of
rust-secp256k1.

This is a backport of secp256k1#1149

Test Plan

ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Fri, Feb 13, 15:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Feb 13, 15:48
PiRK requested review of this revision.Fri, Feb 13, 15:48
teamcity edited the summary of this revision. (Show Details)Fri, Feb 13, 15:48
Harbormaster completed remote builds in B36153: Diff 58320.Fri, Feb 13, 16:09
Fabien accepted this revision.Mon, Feb 16, 09:18
This revision is now accepted and ready to land.Mon, Feb 16, 09:18
PiRK retitled this revision from Remove usage of CHECK from non-test file to [secp256k1] Remove usage of CHECK from non-test file.Mon, Feb 23, 08:59
Closed by commit rABCe58090722e37: [secp256k1] Remove usage of CHECK from non-test file (authored by Tobin C. Harding <me@tobin.cc>, committed by PiRK). · Explain WhyMon, Feb 23, 09:00
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe58090722e37: [secp256k1] Remove usage of CHECK from non-test file.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
12 lines

Diff 58364

View Options

src/secp256k1/src/ecmult_impl.h

Loading...