Differential D19750

netbase: always initialize m_is_unix_socket in the Proxy constructor
ClosedPublic
Actions

Authored by PiRK on Mar 27 2026, 16:02.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc6a799d06202: netbase: always initialize m_is_unix_socket in the Proxy constructor

Summary

This was missed in D19737, and causes a failure in the UBSAN build.

~/bitcoin-abc/src/./netbase.h:83:13: runtime error: load of value 8, which is not a valid value for type 'bool'
...

UndefinedBehaviorSanitizer: invalid-bool-load ~/bitcoin-abc/src/./netbase.h:83:13

Test Plan

cmake .. -GNinja  -DENABLE_SANITIZERS=undefined -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 27 2026, 16:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2026, 16:02

PiRK requested review of this revision.Mar 27 2026, 16:02

Fabien accepted this revision.Mar 27 2026, 16:03

This revision is now accepted and ready to land.Mar 27 2026, 16:03

@bot build-ubsan

teamcity awarded a token.Mar 27 2026, 16:04

Harbormaster completed remote builds in B36448: Diff 58775.Mar 27 2026, 16:21

Closed by commit rABCc6a799d06202: netbase: always initialize m_is_unix_socket in the Proxy constructor (authored by PiRK). · Explain WhyMar 27 2026, 16:47

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc6a799d06202: netbase: always initialize m_is_unix_socket in the Proxy constructor.

Revision Contents
Changeset List

Path

Size

src/

netbase.h

2 lines

Diff 58776

View Options

netbase: always initialize m_is_unix_socket in the Proxy constructorClosedPublicActions