Use ecash-lib instead, just like cashtab. Suggested here: https://reviews.bitcoinabc.org/D19802?id=58950#inline-85825
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC8703ff2bc96d: [marlin] Remove dependency to bip39
pnpm run test:e2e pnpm run android # check the mnemonic loads and can be replaced
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
big win to lose a critical crypto third party dep like this
not sure if i'm missing something on the validateMnemonic duplication; seems unrelated to this diff as could have also been defined once before
| apps/marlin-wallet/web/cypress/e2e/mnemonic.cy.ts | ||
|---|---|---|
| 27–46 ↗ | (On Diff #58976) | Probably better now to use the validateMnemonic as it is defined and exported in mnemonic.ts no? Rather than redefine it here? |