Page MenuHomePhabricator
Differential D19952

[electrum] ConfigKeys (7/n): GUI configs
ClosedPublic
Actions

Authored by PiRK on Wed, May 6, 16:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4866ba28dd5a: [electrum] ConfigKeys (7/n): GUI configs
Summary

Continue the work started in D19921. This focuses on GUI display configurations.

Test Plan

ninja check-electrum check-electrum-functional

Run the GUI, check that settings are persisted accross restarts (show/hide console tab or address format button)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, May 6, 16:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, May 6, 16:04
PiRK updated this revision to Diff 59348.Wed, May 6, 16:11

found the issue: TIL that errors in a @property getter method are obfuscated by a simpler AttributeError: 'ElectrumGui' object has no attribute 'linux_qt_use_custom_fontconfig'

Harbormaster completed remote builds in B36812: Diff 59347.Wed, May 6, 16:11
PiRK published this revision for review.Wed, May 6, 16:11
PiRK updated this revision to Diff 59349.Wed, May 6, 16:16

self-review: fix the default for linux_qt_use_custom_fontconfig

Harbormaster completed remote builds in B36813: Diff 59348.Wed, May 6, 16:18
Harbormaster completed remote builds in B36814: Diff 59349.Wed, May 6, 16:24
Fabien accepted this revision.Thu, May 7, 08:25
This revision is now accepted and ready to land.Thu, May 7, 08:25
Closed by commit rABC4866ba28dd5a: [electrum] ConfigKeys (7/n): GUI configs (authored by PiRK). · Explain WhyThu, May 7, 09:08
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4866ba28dd5a: [electrum] ConfigKeys (7/n): GUI configs.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
4 lines
26 lines
electrumabc_gui/
qt/
28 lines
13 lines
10 lines
12 lines

Diff 59363

View Options

electrum/electrumabc/daemon.py

Loading...
View Options

electrum/electrumabc/simple_config.py

Loading...
View Options

electrum/electrumabc_gui/qt/__init__.py

Loading...
View Options

electrum/electrumabc_gui/qt/exception_window.py

Loading...
View Options

electrum/electrumabc_gui/qt/main_window.py

Loading...
View Options

electrum/electrumabc_gui/qt/settings_dialog.py

Loading...