Page MenuHomePhabricator
Differential D20222

[ecash-wallet] Support ALP token txs to arbitrary number of recipients with arbitrary number of tokenIds
ClosedPublic
Actions

Authored by bytesofman on Tue, Jul 7, 17:47.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC75a62afad7c1: [ecash-wallet] Support ALP token txs to arbitrary number of recipients with…
Summary

Allow users to send any amount of tokens to any amount of recipients

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Tue, Jul 7, 17:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jul 7, 17:47
Harbormaster completed remote builds in B37256: Diff 60047.Tue, Jul 7, 17:57
bytesofman updated this revision to Diff 60051.Tue, Jul 7, 19:04

version bumps, tests, confirm 3 different tokens is the most that can be sent in a single tx

Harbormaster completed remote builds in B37260: Diff 60051.Tue, Jul 7, 19:15
bytesofman updated this revision to Diff 60061.Tue, Jul 7, 21:42

more tests

Harbormaster completed remote builds in B37261: Diff 60061.Tue, Jul 7, 22:05
bytesofman published this revision for review.Tue, Jul 7, 23:31
bytesofman planned changes to this revision.Wed, Jul 8, 17:17

improve test, limit functionality to send only (validation against combined actions for chained txs). we could extend later for "just do it all" actions but that is more of a general thing, parsing an action into sub-actions and executing them all sequentially

bytesofman updated this revision to Diff 60066.Wed, Jul 8, 19:02

only support multitoken chained with send action only

Harbormaster completed remote builds in B37266: Diff 60066.Wed, Jul 8, 19:14
PiRK added a subscriber: PiRK.Thu, Jul 9, 07:10
PiRK added inline comments.
modules/ecash-wallet/src/wallet.ts
730–734 ↗(On Diff #60066)

is there a need for this specific error message, vs just letting the next error happen? Is there test coverage for the two specific errors?

PiRK accepted this revision.Thu, Jul 9, 09:23

otherwise lgtm

This revision is now accepted and ready to land.Thu, Jul 9, 09:23
bytesofman marked an inline comment as done.Thu, Jul 9, 12:45
bytesofman added inline comments.
modules/ecash-wallet/src/wallet.ts
730–734 ↗(On Diff #60066)

no, it's an artifact, good catch, will take it out

Closed by commit rABC75a62afad7c1: [ecash-wallet] Support ALP token txs to arbitrary number of recipients with… (authored by bytesofman). · Explain WhyThu, Jul 9, 12:51
This revision was automatically updated to reflect the committed changes.
bytesofman marked an inline comment as done.
bytesofman added a commit: rABC75a62afad7c1: [ecash-wallet] Support ALP token txs to arbitrary number of recipients with….

Revision Contents
Changeset List

PathSize
modules/
ecash-agora/
4 lines
2 lines
ecash-wallet/
7 lines
1 line
2 lines
src/
340 lines
361 lines
test/
272 lines
845 lines

Diff 60073

View Options

modules/ecash-agora/README.md

Loading...
View Options

modules/ecash-agora/package.json

Loading...
View Options

modules/ecash-wallet/README.md

Loading...
View Options

modules/ecash-wallet/chained.md

Loading...
View Options

modules/ecash-wallet/package.json

Loading...
View Options

modules/ecash-wallet/src/wallet.test.ts

Loading...
View Options

modules/ecash-wallet/src/wallet.ts

Loading...
View Options

modules/ecash-wallet/test/hdTransactions.test.ts

Loading...
View Options

modules/ecash-wallet/test/transactions.test.ts

Loading...