This is a backport of core#23047
The wallet.py changes were backported in D16444
Differential D20410
test: Use MiniWallet in mempool_persist Authored by PiRK on Jul 31 2026, 08:07. Project Tags None Referenced Files None Subscribers None
Details
This is a backport of core#23047 The wallet.py changes were backported in D16444 ninja check-functional
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed. Diff : committed changes only (\(\ ──────────────────────────────────────────────────────────────────────── major [Functional Correctness]
→ ]8;;vscode://file//work/test/functional/mempool_persist.py:152test/functional/mempool_persist.py:152-153]8;;
Exclude clusterid from the restart comparison.
Line 153 compares an in-memory cluster identifier that can change when the
node rebuilds the mempool. The assertion can fail although mempool
persistence is correct. The upstream test normalizes clusterid before
this comparison. (raw.githubusercontent.com)
Proposed fix
self.log.debug("Verify all fields are loaded correctly")
- assert_equal(last_entry, self.nodes[0].getmempoolentry(txid=last_txid))
+ new_entry = self.nodes[0].getmempoolentry(txid=last_txid)
+ assert_equal(
+ {**last_entry, "clusterid": None},
+ {**new_entry, "clusterid": None},
+ )──────────────────────────────────────── Major 1 1 file reviewed:
──────────────────────────────────────── Print all AI prompts: coderabbit review --show-prompts |