Page MenuHomePhabricator
Differential D20443

Add a Currency::getTicker() shortcut
ClosedPublic
Actions

Authored by Fabien on Wed, Aug 5, 19:38.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC6bfc68020f14: Add a Currency::getTicker() shortcut
Summary

Instead of get()'ing the currency then accessing the ticker member. This makes it possible to hide the underlying type and store a string_view so we can use a constexpr constructor for Currency. With SSO the performance impact is negligible.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Wed, Aug 5, 19:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Aug 5, 19:38
teamcity added a comment.Wed, Aug 5, 19:41

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Goodbye, 3-hour code review sessions.

────────────────────────────────────────
Review complete
No findings ✔

15 files reviewed:

  • src/consensus/amount.cpp
  • src/consensus/amount.h
  • src/feerate.cpp
  • src/init.cpp
  • src/qt/test/wallettests.cpp
  • src/rpc/avalanche.cpp
  • src/rpc/blockchain.cpp
  • src/rpc/mempool.cpp
  • src/rpc/misc.cpp
  • src/rpc/net.cpp

... and 5 more files
────────────────────────────────────────

Harbormaster completed remote builds in B37772: Diff 60768.Wed, Aug 5, 19:55
Fabien published this revision for review.Wed, Aug 5, 20:07
Fabien added a child revision: D20441: util: Avoid invalid integer negation in FormatMoney and its opposite.
bytesofman accepted this revision.Thu, Aug 6, 11:20
This revision is now accepted and ready to land.Thu, Aug 6, 11:20
Closed by commit rABC6bfc68020f14: Add a Currency::getTicker() shortcut (authored by Fabien). · Explain WhyThu, Aug 6, 11:52
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC6bfc68020f14: Add a Currency::getTicker() shortcut.

Revision Contents
Changeset List

PathSize
src/
consensus/
4 lines
8 lines
2 lines
2 lines
qt/
test/
2 lines
rpc/
10 lines
8 lines
10 lines
2 lines
2 lines
8 lines
2 lines
test/
2 lines
wallet/
2 lines
39 lines

Diff 60799

View Options

src/consensus/amount.h

Loading...
View Options

src/consensus/amount.cpp

Loading...
View Options

src/feerate.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/rpc/avalanche.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mempool.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/rpc/rawtransaction_util.cpp

Loading...
View Options

src/test/amount_tests.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...