Paths

Table of Contentst

Differential D20447

[electrum] Remove experimental eCash Alias (.xec) resolution
ClosedPublic
Actions

Authored by bytesofman on Thu, Aug 6, 08:17.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC09f7c5eabdc7: [electrum] Remove experimental eCash Alias (.xec) resolution

Summary

Drop the gated --enable-aliases eCash Alias feature that
resolved name.xec via alias.etokens.cash. The feature was experimental
and is no longer used. OpenAlias resolution is unchanged. Existing
contacts previously saved with type ecash still load and display.

Test Plan

cd electrum && python3 -m electrumabc.tests.test_alias
Confirm ./electrum-abc --help no longer lists --enable-aliases
In the GUI, Pay To still resolves OpenAlias; foo.xec is not resolved
Contacts tab no longer offers "Add eCash Alias"; existing ecash-type contacts still appear if present in a wallet

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Thu, Aug 6, 08:17

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Clippy has nothing on me.

────────────────────────────────────────
Review complete
No findings ✔

8 files reviewed:

electrum/RELEASE-NOTES.md
electrum/electrumabc/alias.py
electrum/electrumabc/commands.py
electrum/electrumabc/simple_config.py
electrum/electrumabc_gui/qt/contact_list.py
electrum/electrumabc_gui/qt/main_window.py
electrum/electrumabc_gui/qt/paytoedit.py
electrum/electrumabc_gui/qt/send_tab.py

────────────────────────────────────────

Harbormaster completed remote builds in B37782: Diff 60783.Thu, Aug 6, 08:35

bytesofman published this revision for review.Thu, Aug 6, 08:36

Fabien requested changes to this revision.Thu, Aug 6, 08:42

Fabien added a subscriber: Fabien.

Fabien added inline comments.

electrum/RELEASE-NOTES.md
12 ↗	(On Diff #60783)	Wrong place it's released already

This revision now requires changes to proceed.Thu, Aug 6, 08:42

Back out RELEASE-NOTES.md change from this diff.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Stack Overflow called, they want their code back.

────────────────────────────────────────
Review complete
No findings ✔

7 files reviewed:

electrum/electrumabc/alias.py
electrum/electrumabc/commands.py
electrum/electrumabc/simple_config.py
electrum/electrumabc_gui/qt/contact_list.py
electrum/electrumabc_gui/qt/main_window.py
electrum/electrumabc_gui/qt/paytoedit.py
electrum/electrumabc_gui/qt/send_tab.py

────────────────────────────────────────

Harbormaster completed remote builds in B37787: Diff 60792.Thu, Aug 6, 10:03

Fabien accepted this revision.Thu, Aug 6, 14:02

This revision is now accepted and ready to land.Thu, Aug 6, 14:02

Closed by commit rABC09f7c5eabdc7: [electrum] Remove experimental eCash Alias (.xec) resolution (authored by bytesofman). · Explain WhyThu, Aug 6, 14:56

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC09f7c5eabdc7: [electrum] Remove experimental eCash Alias (.xec) resolution.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

83 lines

11 lines

simple_config.py

1 line

electrumabc_gui/

qt/

contact_list.py

154 lines

7 lines

23 lines

2 lines

Diff 60802

electrum/electrumabc/alias.py

Loading...

electrum/electrumabc/commands.py

Loading...

electrum/electrumabc/simple_config.py

Loading...

electrum/electrumabc_gui/qt/contact_list.py

Loading...

electrum/electrumabc_gui/qt/main_window.py

Loading...

electrum/electrumabc_gui/qt/paytoedit.py

Loading...

electrum/electrumabc_gui/qt/send_tab.py

Loading...