Page MenuHomePhabricator

[herald, explorer] Parse minepoolis.com
ClosedPublic

Authored by bytesofman on Thu, Aug 6, 11:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe63499adf41b: [herald, explorer] Parse minepoolis.com
Summary

Identify minepoolis.com from coinbase data (and its consistent
payout script) using blocks 960537 and 960844 as reference.

Test Plan
  • cd apps/ecash-herald && npm test -- --grep getMinerFromCoinbaseTx
  • cd web/explorer/explorer-server && cargo test render_miner

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) What happens in code review stays in code review.

────────────────────────────────────────
Review complete
No findings ✔

3 files reviewed:

  • apps/ecash-herald/constants/miners.ts
  • apps/ecash-herald/test/fixtures/miners.ts
  • web/explorer/explorer-server/src/templating/filters.rs

────────────────────────────────────────

bytesofman published this revision for review.Thu, Aug 6, 12:24
This revision is now accepted and ready to land.Thu, Aug 6, 14:12
This revision was automatically updated to reflect the committed changes.