SECURITY.md is the de facto standard due to Github pushing for it. This also results in no apparent disclosure info on the Security tab of Github: https://github.com/Bitcoin-ABC/bitcoin-abc/security
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC436f63d7d78f: Rename DISCLOSURE_POLICY.md to SECURITY.md
read it
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) Your code has 99 problems and bug fixes ain't none of 'em.
────────────────────────────────────────────────────────────────────────
major [Security & Privacy] → ]8;;vscode://file//work/SECURITY.md:23SECURITY.md:23-27]8;; Pin encryption to the documented fingerprint. Use the full fingerprint as --recipient instead of security@bitcoinabc.org. Add --armor when writing the encrypted output to a .asc file. Verify the imported fingerprint against a trusted Bitcoin ABC source before encryption.
────────────────────────────────────────
Review complete
1 finding ✔
Major 1
3 files reviewed:
- CONTRIBUTING.md
- README.md
- SECURITY.md
────────────────────────────────────────
Print all AI prompts: coderabbit review --show-prompts
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) All idioms must be learned. Good idioms only need to be learned once. - Alan Cooper
────────────────────────────────────────────────────────────────────────
minor [Functional Correctness] → ]8;;vscode://file//work/.github/ISSUE_TEMPLATE.md:5.github/ISSUE_TEMPLATE.md:5]8;; Fix the security-policy link. Line 5 leaves .html outside the Markdown link. Use the repository-root path from .github/ISSUE_TEMPLATE.md. Proposed fix -For reporting security issues, please read instructions at [SECURITY](/SECURITY.md).html. +For reporting security issues, please read instructions at [SECURITY](../SECURITY.md).
────────────────────────────────────────────────────────────────────────
minor [Security & Privacy] → ]8;;vscode://file//work/SECURITY.md:19SECURITY.md:19]8;; Specify that reporters must provide a public PGP key. Line 19 says “A PGP key/fingerprint”. State “public PGP key” explicitly, and tell reporters never to send a private key. Proposed fix -* A PGP key/fingerprint for us to provide encrypted responses to your disclosure. +* A public PGP key/fingerprint for us to provide encrypted responses to your disclosure. Never send a private key.
────────────────────────────────────────────────────────────────────────
minor [Maintainability & Code Quality] → ]8;;vscode://file//work/SECURITY.md:64SECURITY.md:64-70]8;; Replace the stale Zcash disclosure-policy link. Line 70 points to responsible_disclosure.md, which returns 404. The current Zcash policy is SECURITY.md. ([]()) Proposed fix - * [Disclosure Policy](https://github.com/zcash/zcash/blob/master/responsible_disclosure.md) + * [Disclosure Policy](https://github.com/zcash/zcash/blob/master/SECURITY.md)
────────────────────────────────────────────────────────────────────────
minor [Functional Correctness] → ]8;;vscode://file//work/SECURITY.md:48SECURITY.md:48-50]8;; Add --armor when writing to .asc. GnuPG writes binary OpenPGP data by default. Add --armor or rename the output file to .gpg.
────────────────────────────────────────
Review complete
4 findings ✔
Minor 4
4 files reviewed:
- .github/ISSUE_TEMPLATE.md
- CONTRIBUTING.md
- README.md
- SECURITY.md
────────────────────────────────────────
Print all AI prompts: coderabbit review --show-prompts