This is a partial backport of core#28960
https://github.com/bitcoin/bitcoin/pull/28960/changes/4abde2c4e3fd9b66394b79874583bdc2a9132c36
Depends on D20503
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC900d2860fa90: [refactor] Make MainSignals RAII styled
ninja all check-all
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Tail of the build log:
[487/546] bitcoin: testing txpackage_tests [488/546] Running utility command for check-bitcoin-txpackage_tests [489/546] bitcoin: testing validation_flush_tests [490/546] bitcoin: testing util_tests [491/546] Running utility command for check-bitcoin-validation_flush_tests [492/546] Running utility command for check-bitcoin-util_tests [493/546] bitcoin: testing validation_chainstate_tests [494/546] bitcoin: testing blockindex_comparator_tests [495/546] Running utility command for check-bitcoin-validation_chainstate_tests [496/546] Running utility command for check-bitcoin-blockindex_comparator_tests [497/546] bitcoin: testing txrequest_tests [498/546] bitcoin: testing server_tests [499/546] Running utility command for check-bitcoin-txrequest_tests [500/546] Running utility command for check-bitcoin-server_tests [501/546] bitcoin: testing db_tests [502/546] Running utility command for check-bitcoin-db_tests [503/546] bitcoin: testing init_tests [504/546] bitcoin: testing validation_tests [505/546] Running utility command for check-bitcoin-validation_tests [506/546] Running utility command for check-bitcoin-init_tests [507/546] bitcoin: testing ismine_tests [508/546] Running utility command for check-bitcoin-ismine_tests [509/546] bitcoin: testing txvalidationcache_tests [510/546] bitcoin: testing scriptpubkeyman_tests [511/546] Running utility command for check-bitcoin-scriptpubkeyman_tests [512/546] Running utility command for check-bitcoin-txvalidationcache_tests [513/546] bitcoin: testing validationinterface_tests [514/546] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o [515/546] Running utility command for check-bitcoin-validationinterface_tests [516/546] bitcoin: testing walletdb_tests [517/546] Running utility command for check-bitcoin-walletdb_tests [518/546] bitcoin: testing validation_block_tests [519/546] bitcoin: testing psbt_wallet_tests [520/546] Running utility command for check-bitcoin-validation_block_tests [521/546] Running utility command for check-bitcoin-psbt_wallet_tests [522/546] Linking CXX executable src/qt/test/test_bitcoin-qt [523/546] bitcoin: testing wallet_crypto_tests [524/546] Running utility command for check-bitcoin-wallet_crypto_tests [525/546] bitcoin: testing scriptnum_63bit_tests [526/546] Running utility command for check-bitcoin-scriptnum_63bit_tests [527/546] bitcoin: testing random_tests [528/546] Running utility command for check-bitcoin-random_tests [529/546] bitcoin-qt: testing test_bitcoin-qt [530/546] Running bitcoin-qt test suite PASSED: bitcoin-qt test suite [531/546] bitcoin: testing transaction_tests [532/546] Running utility command for check-bitcoin-transaction_tests [533/546] bitcoin: testing validation_chainstatemanager_tests [534/546] bitcoin: testing coins_tests [535/546] Running utility command for check-bitcoin-validation_chainstatemanager_tests [536/546] Running utility command for check-bitcoin-coins_tests [537/546] bitcoin: testing wallet_tests [538/546] Running utility command for check-bitcoin-wallet_tests [539/546] bitcoin: testing coinselector_tests [540/546] Running utility command for check-bitcoin-coinselector_tests [541/546] secp256k1: testing secp256k1-tests [542/546] Running secp256k1 test suite PASSED: secp256k1 test suite ninja: build stopped: cannot make progress due to previous errors. Build build-clang failed with exit code 1
Tail of the build log:
[416/604] Linking C executable src/secp256k1/ecmult-bench [417/604] Linking C executable src/secp256k1/bench [418/604] Linking C executable src/secp256k1/examples/ecdh_example [419/604] Linking C executable src/secp256k1/examples/ecdsa_example [420/604] Linking C executable src/secp256k1/examples/schnorr_example [421/604] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o [422/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o [423/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o [424/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o [425/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o [426/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o [427/604] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o [428/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o [429/604] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o [430/604] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o [431/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o [432/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o [433/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o [434/604] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o [435/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o [436/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o [437/604] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o [438/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o [439/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o [440/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o [441/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o [442/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o [443/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o [444/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o [445/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o [446/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o [447/604] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o [448/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o [449/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o [450/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o [451/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o [452/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o [453/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o [454/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o [455/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o [456/604] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o [457/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o [458/604] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o [459/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o [460/604] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o [461/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o [462/604] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o [463/604] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o [464/604] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o [465/604] Linking CXX executable src/iguana/iguana [466/604] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o [467/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o [468/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o [469/604] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o [470/604] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o [471/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o [472/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o [473/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o ninja: build stopped: cannot make progress due to previous errors. Build build-clang-tidy failed with exit code 1
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) Use assertions to prevent the impossible. Assertions validate your assumptions. Use them to protect your code from an uncertain world.
────────────────────────────────────────
Review complete
No findings ✔
5 files reviewed:
- src/bitcoin-chainstate.cpp
- src/init.cpp
- src/test/util/setup_common.cpp
- src/validationinterface.cpp
- src/validationinterface.h
────────────────────────────────────────
Tail of the build log:
2026-08-25T14:57:56.688335Z [/work/src/validation.cpp:6487] [bool Chainstate::ResizeCoinsCaches(size_t, size_t)] [Chainstate [ibd] @ height -1 (null)] resized coinstip cache to 1014.0 MiB 2026-08-25T14:57:56.688648Z [/work/src/validation.cpp:2993] [bool Chainstate::ConnectTip(BlockValidationState&, BlockPolicyValidationState&, CBlockIndex*, const std::shared_ptr<const CBlock>&, DisconnectedBlockTransactions&, const avalanche::Processor*, ChainstateRole)] [bench] - Load block from disk: 0.08ms 2026-08-25T14:57:56.688721Z [/work/src/validationinterface.cpp:263] [void CMainSignals::BlockChecked(const CBlock&, const BlockValidationState&)] [validation] BlockChecked: block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f state=Valid 2026-08-25T14:57:56.688781Z [/work/src/validation.cpp:3093] [bool Chainstate::ConnectTip(BlockValidationState&, BlockPolicyValidationState&, CBlockIndex*, const std::shared_ptr<const CBlock>&, DisconnectedBlockTransactions&, const avalanche::Processor*, ChainstateRole)] [bench] - Connect total: 0.13ms [0.00s (0.13ms/blk)] 2026-08-25T14:57:56.688814Z [/work/src/validation.cpp:3104] [bool Chainstate::ConnectTip(BlockValidationState&, BlockPolicyValidationState&, CBlockIndex*, const std::shared_ptr<const CBlock>&, DisconnectedBlockTransactions&, const avalanche::Processor*, ChainstateRole)] [bench] - Flush: 0.04ms [0.00s (0.04ms/blk)] 2026-08-25T14:57:56.688870Z [/work/src/validation.cpp:3114] [bool Chainstate::ConnectTip(BlockValidationState&, BlockPolicyValidationState&, CBlockIndex*, const std::shared_ptr<const CBlock>&, DisconnectedBlockTransactions&, const avalanche::Processor*, ChainstateRole)] [bench] - Writing chainstate: 0.05ms [0.00s (0.05ms/blk)] 2026-08-25T14:57:56.688959Z [/work/src/validation.cpp:2802] [void UpdateTipLog(const CCoinsViewCache&, const CBlockIndex*, const CChainParams&, const std::string&, const std::string&)] UpdateTip: new best=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f height=0 version=0x00000001 log2_work=32.000022 tx=1 date='2009-01-03T18:15:05Z' progress=0.000000 cache=0.3MiB(0txo) 2026-08-25T14:57:56.688992Z [/work/src/validation.cpp:3143] [bool Chainstate::ConnectTip(BlockValidationState&, BlockPolicyValidationState&, CBlockIndex*, const std::shared_ptr<const CBlock>&, DisconnectedBlockTransactions&, const avalanche::Processor*, ChainstateRole)] [bench] - Connect postprocess: 0.12ms [0.00s (0.12ms/blk)] 2026-08-25T14:57:56.689022Z [/work/src/validation.cpp:3148] [bool Chainstate::ConnectTip(BlockValidationState&, BlockPolicyValidationState&, CBlockIndex*, const std::shared_ptr<const CBlock>&, DisconnectedBlockTransactions&, const avalanche::Processor*, ChainstateRole)] [bench] - Connect block: 0.42ms [0.00s (0.42ms/blk)] 2026-08-25T14:57:56.689072Z [/work/src/validationinterface.cpp:234] [void CMainSignals::BlockConnected(ChainstateRole, const std::shared_ptr<const CBlock>&, const CBlockIndex*)] [validation] Enqueuing BlockConnected: block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f block height=0 2026-08-25T14:57:56.689214Z [/work/src/validationinterface.cpp:234] [CMainSignals::BlockConnected(ChainstateRole, const std::shared_ptr<const CBlock>&, const CBlockIndex*)::<lambda()>] [validation] BlockConnected: block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f block height=0 2026-08-25T14:57:56.689541Z [/work/src/txmempool.cpp:403] [void CTxMemPool::check(const CCoinsViewCache&, int64_t) const] [mempool] Checking mempool with 0 transactions and 0 inputs 2026-08-25T14:57:56.689671Z [/work/src/validationinterface.cpp:191] [void CMainSignals::UpdatedBlockTip(const CBlockIndex*, const CBlockIndex*, bool)] [validation] Enqueuing UpdatedBlockTip: new block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f fork block hash=null (in IBD=true) 2026-08-25T14:57:56.689792Z [/work/src/validationinterface.cpp:191] [CMainSignals::UpdatedBlockTip(const CBlockIndex*, const CBlockIndex*, bool)::<lambda()>] [validation] UpdatedBlockTip: new block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f fork block hash=null (in IBD=true) 2026-08-25T14:57:56.691028Z [/work/src/addrdb.cpp:228] [bool CBanDB::Read(banmap_t&, bool&)] Missing or invalid file "/tmp/test_common_Bitcoin ABC/6dd85c56d0351fbaa59f0a9d76a0b241f51e4ae6142c1636ac1b8e434c5e0764/banlist.dat" 2026-08-25T14:57:56.691057Z [/work/src/banman.cpp:31] [BanMan::BanMan(fs::path, const CChainParams&, CClientUIInterface*, int64_t)] Recreating the banlist database 2026-08-25T14:57:56.691193Z [/work/src/banman.cpp:59] [void BanMan::DumpBanlist()] [net] Flushed 0 banned node addresses/subnets to disk 0ms 2026-08-25T14:57:56.691245Z [/work/src/net.cpp:1735] [void CConnman::SetTryNewOutboundPeer(bool)] [net] net: setting try another outbound peer=false 2026-08-25T14:57:56.691291Z [/work/src/net.cpp:2474] [void CConnman::SetNetworkActive(bool)] SetNetworkActive: true 2026-08-25T14:57:56.693876Z [/work/src/net.cpp:1735] [void CConnman::SetTryNewOutboundPeer(bool)] [net] net: setting try another outbound peer=false 2026-08-25T14:57:56.693933Z [/work/src/net.cpp:2474] [void CConnman::SetNetworkActive(bool)] SetNetworkActive: true 2026-08-25T14:57:56.695920Z [/work/src/avalanche/peermanager.cpp:1387] [bool avalanche::PeerManager::loadPeersFromFile(const fs::path&, std::unordered_set<RCUPtr<const avalanche::Proof>, avalanche::SaltedProofHasher>&)] [avalanche] Failed to open avalanche peers file from disk. 2026-08-25T14:57:56.695970Z [/work/src/avalanche/processor.cpp:206] [avalanche::Processor::Processor(avalanche::Config, interfaces::Chain&, CConnman*, ChainstateManager&, CTxMemPool*, CScheduler&, std::unique_ptr<PeerData>, CKey, uint32_t, double, int64_t, uint32_t, uint32_t, Amount, bool, bool, size_t)] [avalanche] Loaded 0 peers from the /tmp/test_common_Bitcoin ABC/6dd85c56d0351fbaa59f0a9d76a0b241f51e4ae6142c1636ac1b8e434c5e0764/avapeers.dat file 2026-08-25T14:57:56.698585Z [/work/src/node/miner.cpp:209] [std::unique_ptr<node::CBlockTemplate> node::BlockAssembler::CreateNewBlock(const CScript&)] CreateNewBlock(): total size: 242 txs: 0 fees: 0 sigChecks 100 2026-08-25T14:57:56.698725Z [/work/src/validation.cpp:2228] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Sanity checks: 0.01ms [0.00s (0.00ms/blk)] 2026-08-25T14:57:56.698912Z [/work/src/validation.cpp:2348] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Fork checks: 0.19ms [0.00s (0.10ms/blk)] 2026-08-25T14:57:56.698975Z [/work/src/validation.cpp:2486] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Connect 1 transactions: 0.06ms (0.057ms/tx, 0.000ms/txin) [0.00s (0.03ms/blk)] 2026-08-25T14:57:56.699047Z [/work/src/validation.cpp:2524] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Verify 0 txins: 0.13ms (0.000ms/txin) [0.00s (0.07ms/blk)] 2026-08-25T14:57:56.699091Z [/work/src/node/miner.cpp:235] [std::unique_ptr<node::CBlockTemplate> node::BlockAssembler::CreateNewBlock(const CScript&)] [bench] CreateNewBlock() addTxs: 0.04ms, validity: 0.72ms (total 0.76ms) 2026-08-25T14:57:56.699321Z [/work/src/node/miner.cpp:209] [std::unique_ptr<node::CBlockTemplate> node::BlockAssembler::CreateNewBlock(const CScript&)] CreateNewBlock(): total size: 242 txs: 0 fees: 0 sigChecks 100 2026-08-25T14:57:56.699442Z [/work/src/validation.cpp:2228] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Sanity checks: 0.01ms [0.00s (0.00ms/blk)] 2026-08-25T14:57:56.699506Z [/work/src/validation.cpp:2348] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Fork checks: 0.07ms [0.00s (0.09ms/blk)] 2026-08-25T14:57:56.699558Z [/work/src/validation.cpp:2486] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Connect 1 transactions: 0.05ms (0.048ms/tx, 0.000ms/txin) [0.00s (0.03ms/blk)] 2026-08-25T14:57:56.699601Z [/work/src/validation.cpp:2524] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Verify 0 txins: 0.09ms (0.000ms/txin) [0.00s (0.08ms/blk)] 2026-08-25T14:57:56.699640Z [/work/src/node/miner.cpp:235] [std::unique_ptr<node::CBlockTemplate> node::BlockAssembler::CreateNewBlock(const CScript&)] [bench] CreateNewBlock() addTxs: 0.02ms, validity: 0.39ms (total 0.41ms) 2026-08-25T14:57:56.699852Z [/work/src/node/miner.cpp:209] [std::unique_ptr<node::CBlockTemplate> node::BlockAssembler::CreateNewBlock(const CScript&)] CreateNewBlock(): total size: 242 txs: 0 fees: 0 sigChecks 100 2026-08-25T14:57:56.699971Z [/work/src/validation.cpp:2228] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Sanity checks: 0.01ms [0.00s (0.00ms/blk)] 2026-08-25T14:57:56.700034Z [/work/src/validation.cpp:2348] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Fork checks: 0.06ms [0.00s (0.08ms/blk)] 2026-08-25T14:57:56.700085Z [/work/src/validation.cpp:2486] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Connect 1 transactions: 0.05ms (0.047ms/tx, 0.000ms/txin) [0.00s (0.04ms/blk)] 2026-08-25T14:57:56.700127Z [/work/src/validation.cpp:2524] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Verify 0 txins: 0.09ms (0.000ms/txin) [0.00s (0.08ms/blk)] 2026-08-25T14:57:56.700166Z [/work/src/node/miner.cpp:235] [std::unique_ptr<node::CBlockTemplate> node::BlockAssembler::CreateNewBlock(const CScript&)] [bench] CreateNewBlock() addTxs: 0.02ms, validity: 0.38ms (total 0.40ms) 2026-08-25T14:57:56.700375Z [/work/src/node/miner.cpp:209] [std::unique_ptr<node::CBlockTemplate> node::BlockAssembler::CreateNewBlock(const CScript&)] CreateNewBlock(): total size: 242 txs: 0 fees: 0 sigChecks 100 2026-08-25T14:57:56.700493Z [/work/src/validation.cpp:2228] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Sanity checks: 0.01ms [0.00s (0.00ms/blk)] 2026-08-25T14:57:56.700563Z [/work/src/validation.cpp:2348] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Fork checks: 0.07ms [0.00s (0.08ms/blk)] 2026-08-25T14:57:56.700615Z [/work/src/validation.cpp:2486] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Connect 1 transactions: 0.05ms (0.048ms/tx, 0.000ms/txin) [0.00s (0.04ms/blk)] 2026-08-25T14:57:56.700657Z [/work/src/validation.cpp:2524] [bool Chainstate::ConnectBlock(const CBlock&, BlockValidationState&, CBlockIndex*, CCoinsViewCache&, BlockValidationOptions, Amount*, bool)] [bench] - Verify 0 txins: 0.09ms (0.000ms/txin) [0.00s (0.08ms/blk)] 2026-08-25T14:57:56.700696Z [/work/src/node/miner.cpp:235] [std::unique_ptr<node::CBlockTemplate> node::BlockAssembler::CreateNewBlock(const CScript&)] [bench] CreateNewBlock() addTxs: 0.02ms, validity: 0.38ms (total 0.40ms) 2026-08-25T14:57:56.700937Z [/work/src/util/thread.cpp:20] [void util::TraceThread(std::string_view, std::function<void()>)] scheduler thread exit terminate called after throwing an instance of 'std::system_error' what(): Operation not permitted Aborted (core dumped) [517/547] Running pow test suite PASSED: pow test suite [532/547] Running bitcoin-qt test suite PASSED: bitcoin-qt test suite [540/547] Running secp256k1 test suite PASSED: secp256k1 test suite [542/547] Running utility command for check-bitcoin-coins_tests ninja: build stopped: cannot make progress due to previous errors. Build build-debug failed with exit code 1
make sure the avalanche processor is destroyed in the same order as in init.cpp. It must be destroyed before m_node.validation_signals is destroyed, because ~Processor() does stuff with the signals (via Processor::chainNotificationsHandler)
Tail of the build log:
/work /work/abc-ci-builds/ai-review Connecting to CodeRabbit... 0s elapsed ✗ Review error Review failed: Failed to start review. Please try again. Build ai-review failed with exit code 1