Paths

Table of Contentst

Differential D20514

Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code
ClosedPublic
Actions

Authored by PiRK on Aug 27 2026, 10:37.

Project Tags

None

Referenced Files

	F86028752: D20514.1791583182.diff
	Thu, Oct 8, 21:59

Subscribers

None

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1985e92f0646: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code

Summary

And add a test to ensure OP_1NEGATE satisfies BIP62 minimal push rule

Co-authored-by: Samuel Dobson <dobsonsa68@gmail.com>

This is a backport of core#17204

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 27 2026, 10:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 27 2026, 10:37

PiRK requested review of this revision.Aug 27 2026, 10:37

teamcity edited the summary of this revision. (Show Details)Aug 27 2026, 10:37

Harbormaster completed remote builds in B37938: Diff 61002.Aug 27 2026, 10:39

Build Bitcoin ABC Diffs / Diff Testing (ai-review) failed.

Tail of the build log:

/work /work/abc-ci-builds/ai-review
Connecting to CodeRabbit... 0s elapsed

  ✗ Review error

  Review failed: Failed to start review. Please try again.

Build ai-review failed with exit code 1

PiRK edited the summary of this revision. (Show Details)Aug 27 2026, 10:57

Fabien accepted this revision.Aug 27 2026, 11:05

This revision is now accepted and ready to land.Aug 27 2026, 11:05

This revision was landed with ongoing or failed builds.Aug 27 2026, 11:07

Closed by commit rABC1985e92f0646: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code. · Explain Why

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1985e92f0646: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code.

Revision Contents
Changeset List

Path

Size

src/

script/

sign.cpp

2 lines

test/

transaction_tests.cpp

2 lines

test/

functional/

rpc_signrawtransaction.py

22 lines

Diff 61010

View Options

src/script/sign.cpp

View Options

src/test/transaction_tests.cpp

View Options

test/functional/rpc_signrawtransaction.py

Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 61010

src/script/sign.cpp

src/test/transaction_tests.cpp

test/functional/rpc_signrawtransaction.py

Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code
ClosedPublic
Actions

Revision Contents
Changeset List