Project Tags

None

Referenced Files

	F86008092: D20517.1791426282.diff
	Wed, Oct 7, 02:24

Subscribers

None

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCe2246423cc47: [electrum] proof editor: handle the case of txid not in wallet

Summary

In D20515 I broke the common case of loading a proof in a different wallet, or loading a proof with coins from multiple wallets.

Don't assume that the wallet has outpoints for the txid.

Test Plan

Create a proof, load it in a different wallet, click generate and check that it does not cause an error.
Test that the test plan in D20515 still works.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 28 2026, 08:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2026, 08:27

PiRK requested review of this revision.Aug 28 2026, 08:27

Harbormaster completed remote builds in B37942: Diff 61016.Aug 28 2026, 08:27

Build Bitcoin ABC Diffs / Diff Testing (ai-review) failed.

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #N/A, branch 'refs/tags/phabricator/diff/61016'
Triggered 2026-08-28 08:27:42 by 'Phabricator Staging (phabricator-staging)'
Started 2026-08-28 08:27:49 on agent 'N/A'
Finished 2026-08-28 08:27:49 with status FAILURE 'Snapshot dependency failed to start: Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout'
VCS revisions: 'BitcoinABC_BitcoinAbcStaging' (Git, instance id 22): '3d47a8e48b0fadcd48134639cc336fa1c5ccf4c0' (branch: 'refs/tags/phabricator/diff/61016', checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/1148594 
TeamCity server version is 2025.03.1 (build 186125), server timezone: GMT (UTC)

[08:27:42]W: bt15 (7s)
[08:27:42]i: TeamCity server version is 2025.03.1 (build 186125)
[08:27:42] : Finalize build settings
[08:27:42] : Collecting changes in 2 VCS roots
[08:27:42] :	 [Collecting changes in 2 VCS roots] VCS Root details
[08:27:42] :		 [VCS Root details] "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[08:27:42] :		 [VCS Root details] "abc-infrastructure" {instance id=24, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[08:27:42]i: Loading current repository state for VCS root 'Bitcoin ABC Staging' (1s)
[08:27:42]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] VCS root 'Bitcoin ABC Staging': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper8875475494329550739.sh ls-remote origin
[08:27:42]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] Loading current repository state for VCS root 'abc-infrastructure' (1s)
[08:27:42]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper15669238099745683028.sh ls-remote origin
[08:27:42]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[08:27:42]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[08:27:43]i: Detecting changes in VCS root 'abc-infrastructure' (used in 'Bitcoin-ABC Infra Checkout', 'Extract Electrum ABC from ABC' and 5 other configurations)
[08:27:43]i: Will collect changes for 'abc-infrastructure' starting from revision 37c5e3cccc5fad59054060c3ceb78ef9e17a2dde
[08:27:43]i: Detecting changes in VCS root 'Bitcoin ABC Staging' (used in 'Diff Testing')
[08:27:43]i: Will collect changes for 'Bitcoin ABC Staging' starting from revision da4bfc751c81366fa970117f1209640ff20d701f
[08:27:44] : Compute revision for 'Bitcoin ABC Staging'
[08:27:44] :	 [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: 3d47a8e48b0fadcd48134639cc336fa1c5ccf4c0
[08:27:44]i:	 [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 96904
[08:27:44] : Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout
[08:27:44] :	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Upper limit revision: 37c5e3cccc5fad59054060c3ceb78ef9e17a2dde
[08:27:44]i:	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] MaxModId = 96851
[08:27:44] :	 [Compute revision for 'Bitcoin ABC Staging'] Computed revision: 3d47a8e48b0fadcd48134639cc336fa1c5ccf4c0
[08:27:44] :	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Computed revision: 37c5e3cccc5fad59054060c3ceb78ef9e17a2dde
[08:27:49]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start

add a simple unittest.

Harbormaster completed remote builds in B37943: Diff 61017.Aug 28 2026, 08:48

Build Bitcoin ABC Diffs / Diff Testing (ai-review) failed.

Tail of the build log:

/work /work/abc-ci-builds/ai-review
Connecting to CodeRabbit... 0s elapsed

  ✗ Review error

  Review failed: Failed to start review. Please try again.

Build ai-review failed with exit code 1

add actual coverage for the exact problematic case (txid not in wallet.txo)

Harbormaster completed remote builds in B37944: Diff 61018.Aug 28 2026, 08:53

Build Bitcoin ABC Diffs / Diff Testing (ai-review) failed.

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #N/A, branch 'refs/tags/phabricator/diff/61018'
Triggered 2026-08-28 08:53:18 by 'Phabricator Staging (phabricator-staging)'
Started 2026-08-28 08:53:31 on agent 'N/A'
Finished 2026-08-28 08:53:31 with status FAILURE 'Snapshot dependency failed to start: Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout'
VCS revisions: 'BitcoinABC_BitcoinAbcStaging' (Git, instance id 22): '66cc7129e01b5f69e4ebd31b01bbf34a9d135656' (branch: 'refs/tags/phabricator/diff/61018', checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/1148606 
TeamCity server version is 2025.03.1 (build 186125), server timezone: GMT (UTC)

[08:53:18]W: bt15 (13s)
[08:53:18]i: TeamCity server version is 2025.03.1 (build 186125)
[08:53:18] : Finalize build settings
[08:53:18] : Collecting changes in 2 VCS roots
[08:53:18] :	 [Collecting changes in 2 VCS roots] VCS Root details
[08:53:18] :		 [VCS Root details] "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[08:53:18] :		 [VCS Root details] "abc-infrastructure" {instance id=24, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[08:53:18]i: Loading current repository state for VCS root 'Bitcoin ABC Staging' (8s)
[08:53:18]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] Loading current repository state for VCS root 'abc-infrastructure' (8s)
[08:53:18]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper5262343111982164987.sh ls-remote origin
[08:53:18]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper16015578325987106088.sh ls-remote origin
[08:53:18]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[08:53:18]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[08:53:19]i: Detecting changes in VCS root 'abc-infrastructure' (used in 'Bitcoin-ABC Infra Checkout', 'Extract Electrum ABC from ABC' and 5 other configurations)
[08:53:19]i: Will collect changes for 'abc-infrastructure' starting from revision 37c5e3cccc5fad59054060c3ceb78ef9e17a2dde
[08:53:19]i: Waiting for completion of current operations for the VCS root 'Bitcoin ABC Staging'
[08:53:25]i: Detecting changes in VCS root 'Bitcoin ABC Staging' (used in 'Diff Testing')
[08:53:25]i: Will collect changes for 'Bitcoin ABC Staging' starting from revision da4bfc751c81366fa970117f1209640ff20d701f
[08:53:26] : Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout
[08:53:26] :	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Upper limit revision: 37c5e3cccc5fad59054060c3ceb78ef9e17a2dde
[08:53:26]i:	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] MaxModId = 96851
[08:53:26] :	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Computed revision: 37c5e3cccc5fad59054060c3ceb78ef9e17a2dde
[08:53:26] : Compute revision for 'Bitcoin ABC Staging'
[08:53:26] :	 [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: 66cc7129e01b5f69e4ebd31b01bbf34a9d135656
[08:53:26]i:	 [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 96906
[08:53:26] :	 [Compute revision for 'Bitcoin ABC Staging'] Computed revision: 66cc7129e01b5f69e4ebd31b01bbf34a9d135656
[08:53:31]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start

remove leftover unused test param

Harbormaster completed remote builds in B37945: Diff 61019.Aug 28 2026, 08:58

Build Bitcoin ABC Diffs / Diff Testing (ai-review) failed.

Tail of the build log:

/work /work/abc-ci-builds/ai-review
Connecting to CodeRabbit... 0s elapsed

  ✗ Review error

  Review failed: Failed to start review. Please try again.

Build ai-review failed with exit code 1

Fabien accepted this revision.Aug 28 2026, 08:59

This revision is now accepted and ready to land.Aug 28 2026, 08:59

This revision was landed with ongoing or failed builds.Aug 28 2026, 11:01

Closed by commit rABCe2246423cc47: [electrum] proof editor: handle the case of txid not in wallet. · Explain Why

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe2246423cc47: [electrum] proof editor: handle the case of txid not in wallet.

[electrum] proof editor: handle the case of txid not in wallet
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 61020

electrum/electrumabc/tests/test_wallet.py

electrum/electrumabc/wallet.py

[electrum] proof editor: handle the case of txid not in walletClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 61020

electrum/electrumabc/tests/test_wallet.py

electrum/electrumabc/wallet.py

[electrum] proof editor: handle the case of txid not in wallet
ClosedPublic
Actions

Revision Contents
Changeset List