Optional coordinator.baseUrl fetches live platformFeePct + platformFeeAddress (cached, mockable). Status advertises platformFeeEnabled. Templates inject the platform-fee out; settle validates it when opted in and still rejects unexpected outs when disabled. Add nginx/HTTPS deploy notes.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Project
- cd apps/alp-dex && pnpm test
- cd apps/alp-dex && pnpm run build
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- alp-dex-coordinator
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 37946 Build 75311: Build Diff ai-review · alp-dex-tests Build 75310: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ai-review) failed.
Tail of the build log:
[12:12:43]i: VCS root 'Bitcoin ABC Staging': remote: Total 27 (delta 16), reused 0 (delta 0), pack-reused 0 [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 3% (1/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 7% (2/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 11% (3/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 14% (4/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 18% (5/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 22% (6/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 25% (7/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 29% (8/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 33% (9/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 37% (10/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 40% (11/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 44% (12/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 48% (13/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 51% (14/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 55% (15/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 59% (16/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 62% (17/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 66% (18/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 70% (19/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 74% (20/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 77% (21/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 81% (22/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 85% (23/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 88% (24/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 92% (25/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 96% (26/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 100% (27/27) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 100% (27/27), 11.53 KiB | 11.53 MiB/s, done. [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 0% (0/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 6% (1/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 12% (2/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 18% (3/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 25% (4/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 31% (5/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 37% (6/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 43% (7/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 50% (8/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 56% (9/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 62% (10/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 68% (11/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 75% (12/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 81% (13/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 87% (14/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 93% (15/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 100% (16/16) [12:12:43]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 100% (16/16), completed with 16 local objects. [12:12:44]i: VCS root 'Bitcoin ABC Staging': From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging [12:12:44]i: VCS root 'Bitcoin ABC Staging': * [new tag] phabricator/base/61021 -> phabricator/base/61021 [12:12:44]i: VCS root 'Bitcoin ABC Staging': * [new tag] phabricator/diff/61021 -> phabricator/diff/61021 [12:12:45]i: Done collecting changes for 'Bitcoin ABC Staging': 1 changes collected 1 changes persisted, total time: 6s,370ms, persisting time: 5ms [12:12:46] : Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout [12:12:46] : [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Upper limit revision: 37c5e3cccc5fad59054060c3ceb78ef9e17a2dde [12:12:46]i: [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] MaxModId = 96851 [12:12:46] : Compute revision for 'Bitcoin ABC Staging' [12:12:46] : [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: b322da62d42fff8c6065d0ea11bdfa2594334ee4 [12:12:46]i: [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 96912 [12:12:46] : [Compute revision for 'Bitcoin ABC Staging'] Computed revision: b322da62d42fff8c6065d0ea11bdfa2594334ee4 [12:12:46] : [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Computed revision: 37c5e3cccc5fad59054060c3ceb78ef9e17a2dde [12:12:54]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start