We use the same mnemonic to derive the "Seller" and "Slush" wallets. But we want to use single-address wallets to simplify inventory management.
Bug uncovered during server test ops.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC5af899d51d74: [alp-dex] Use single-address wallets for seller and slush
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) I wish to make a complaint.
────────────────────────────────────────
Review complete
No findings ✔
6 files reviewed:
- apps/alp-dex/README.md
- apps/alp-dex/SPEC.md
- apps/alp-dex/src/wallet/accounts.ts
- apps/alp-dex/test/walletAccounts.test.ts
- modules/ecash-wallet/src/wallet.test.ts
- modules/ecash-wallet/src/wallet.ts
────────────────────────────────────────
Comment Actions
Drop the ecash-wallet fromMnemonic change. Derive role keys in alp-dex and construct seller/slush with Wallet.fromSk.
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) I've got a very particular set of skills. Skills I have acquired over a very long career. Skills that make me a nightmare for bugs in your code.
────────────────────────────────────────
Review complete
No findings ✔
4 files reviewed:
- apps/alp-dex/README.md
- apps/alp-dex/SPEC.md
- apps/alp-dex/src/wallet/accounts.ts
- apps/alp-dex/test/walletAccounts.test.ts
────────────────────────────────────────