Node DEP0128 fires when consumers require b58-ts before dist/
exists, because main pointed at the gitignored build output. Add a
prepare script so workspace install compiles dist/index.js, declare
exports, and assert require(packageDir) does not emit the deprecation.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Project
- cd modules/b58-ts && pnpm install && pnpm test
- From repo root, node --trace-deprecation -e "require('./modules/b58-ts')" prints no DEP0128
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- b58-ts-main-field
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) Today's code review brought to you by yesterday's caffeine.
────────────────────────────────────────
Review complete
No findings ✔
2 files reviewed:
- modules/b58-ts/package.json
- modules/b58-ts/tests/test.ts
────────────────────────────────────────
Comment Actions
we don't need this. it's only an issue in local dev if the user has not built the package.